[GitHub] HyukjinKwon commented on a change in pull request #23358: [SPARK-26424][SQL] Use java.time API in date/timestamp expressions

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23358: [SPARK-26424][SQL] Use java.time API in date/timestamp expressions
URL: https://github.com/apache/spark/pull/23358#discussion_r243460932
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
 ##########
 @@ -566,7 +566,7 @@ class DateFunctionsSuite extends QueryTest with SharedSQLContext {
 
     // february
     val y1 = "2016-02-29"
-    val y2 = "2017-02-29"
+    val y2 = "2017-02-32"
 
 Review comment:
   Do you roughly know why this has to be changed? Seems like `2017-02-29` date isn't existent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org