You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/20 11:29:49 UTC
[GitHub] [airflow] alexott opened a new pull request #19722: Databricks - allow Azure SP authentication on other clouds
alexott opened a new pull request #19722:
URL: https://github.com/apache/airflow/pull/19722
When other Azure clouds are used (US GovCloud, China, ...) other authentication endpoints should be used. This PR allows to overwrite the authentication endpoint when using other clouds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19722: Databricks - allow Azure SP authentication on other Azure clouds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19722:
URL: https://github.com/apache/airflow/pull/19722#issuecomment-975232796
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19722: Databricks - allow Azure SP authentication on other Azure clouds
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19722:
URL: https://github.com/apache/airflow/pull/19722#discussion_r753910269
##########
File path: docs/apache-airflow-providers-databricks/connections/databricks.rst
##########
@@ -72,6 +72,7 @@ Extra (optional)
* ``azure_tenant_id``: ID of the Azure Active Directory tenant
* ``azure_resource_id``: optional Resource ID of the Azure Databricks workspace (required if Service Principal isn't
a user inside workspace)
+ * ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. Should be specified as hostname with protocol. For example: ``https://login.microsoftonline.de``.
Review comment:
```suggestion
* ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. The endpoint must contain a protocol. For example: ``https://login.microsoftonline.de``.
```
Hostname and protocol are distincts part of a URL, and it is technically not correct to say “hostname with protocol”.
##########
File path: docs/apache-airflow-providers-databricks/connections/databricks.rst
##########
@@ -72,6 +72,7 @@ Extra (optional)
* ``azure_tenant_id``: ID of the Azure Active Directory tenant
* ``azure_resource_id``: optional Resource ID of the Azure Databricks workspace (required if Service Principal isn't
a user inside workspace)
+ * ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. Should be specified as hostname with protocol. For example: ``https://login.microsoftonline.de``.
Review comment:
```suggestion
* ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. The value must contain a protocol. For example: ``https://login.microsoftonline.de``.
```
Hostname and protocol are distincts part of a URL, and it is technically not correct to say “hostname with protocol”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19722: Databricks - allow Azure SP authentication on other Azure clouds
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19722:
URL: https://github.com/apache/airflow/pull/19722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org