[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #906: Avoid using Get interface to obtain metadata when iterating data during migration

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #906:
URL: https://github.com/apache/incubator-kvrocks/pull/906#discussion_r977296609


##########
src/slot_migrate.cc:
##########
@@ -302,7 +302,7 @@ Status SlotMigrate::SendSnapshot(void) {
 
     // Add key's constructed cmd to restore_cmds, send pipeline
     // or not according to current_pipeline_size_
-    auto stat = MigrateOneKey(rocksdb::Slice(user_key), &restore_cmds);
+    auto stat = MigrateOneKey(rocksdb::Slice(user_key), iter->value(), &restore_cmds);

Review Comment:
   ```suggestion
       auto stat = MigrateOneKey(user_key, iter->value(), &restore_cmds);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org