You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by Alexander Saydakov <sa...@yahooinc.com.INVALID> on 2024/12/14 00:07:54 UTC
Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1
I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own
environment?
We can remove the .zip after extraction. That would be a slight change to
Makefile.
workflow_settings.yaml is not in version control. I think it is a temporary
file, side effect of running some cloud utils.
On Fri, Dec 13, 2024 at 3:55 PM Lee Rhodes <le...@gmail.com> wrote:
> +1(binding)
>
> Whew! I made it through all the way to "make test" and everything passed!
>
> I have a couple of minor comments, which should not impact the release:
>
> - In the README.md file there needs to be a blank line prior to "```
> .... ```" blocks. Although these blocks rendered ok in Chrome, these
> blocks may not render in all browsers. I use MacDown to check these kinds
> of formatting issues.
> - The root directory is looking messy with all of the build related
> stuff in it. The user's attention should be focused on the sketch
> directories and the following directories and files distract from that:
> - CICD/
> - datasketches-cpp/ (sym-link)
> - datasketches-cpp-5.1.0/
> - emsdk/
> - includes/
> - cloudbuild.yaml
> - datasketches-cpp-5.1.0.zip
> - readme_generator.py
> - substitute_and_run.sh
> - workflow_settings.yaml
>
> Can most of this stuff be put in a "build" directory?
>
>
>
> On Wed, Dec 11, 2024 at 2:20 PM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
>
>> Hello Apache DataSketches PMC and Community,
>>
>>
>> This is a call for vote to release
>> Apache DataSketches-bigquery candidate version 1.0.0-rc1
>>
>> Apache DataSketches library functions for Google BigQuery.
>>
>> This is the first release of the product.
>>
>> Source repository:
>>
>> - https://github.com/apache/datasketches-bigquery
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDkts3l-n_iU$>
>>
>>
>> Git Tag for this release:
>>
>> -
>> https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDktsTs6TUPo$> on
>> branch 1.0.x
>>
>>
>> Git HashId for this release is: 407ae7519e10b3f8e5965cad2c9de5475a8bb444
>>
>> The Release Candidate Zip Repository:
>>
>> -
>> https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDktsG43CGGo$>
>>
>>
>> The public signing key can be found in the KEYS file:
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>>
>>
>>
>> The artifacts have been signed with key:
>>
>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>> alsay@apache.org>
>>
>>
>> Build & Test Guide:
>>
>> -
>> https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDkts_CSTMpg$>
>>
>>
>> The vote will be performed as follows:
>>
>> - This letter will be published on dev@ and remain open for at least
>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>> votes or a majority of (+1) PMC votes are acquired. Anyone in the
>> community can vote.
>>
>>
>> Please vote accordingly:
>>
>>
>> [ ] +1 approve
>>
>> [ ] +0 no opinion
>>
>> [ ] -1 disapprove with the reason
>>
>>
>> Thank you,
>>
>> Alexander Saydakov
>>
>> alsay@apache.org
>>
>>
>>
Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1
Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
Hi all,
This vote is now closed. There were 3 binding +1 votes and no other votes.
Thank you to those who voted.
On Mon, Dec 16, 2024 at 4:38 PM Alexander Saydakov <sa...@yahooinc.com>
wrote:
> +1
>
> - checked GPG signature and SHA512
> - LICENSE and NOTICE look good
> - 'make', 'make install', 'make test' successful
>
>
> On Mon, Dec 16, 2024 at 3:45 PM Jon Malkin <jo...@gmail.com> wrote:
>
>> +1 (binding)
>>
>> I checked:
>> - checksum + signature
>> - make/make install/make test worked
>> - LICENSE and NOTICE look good
>>
>> I don't have any particular problem with the current directory
>> structure. I think the general expectation is that few people will
>> interact with the raw git repo as opposed to using the sketches, and
>> the website and documentation surfaced through BigQuery will matter
>> more for usage help.
>>
>> jon
>>
>> On Fri, Dec 13, 2024 at 4:17 PM Lee Rhodes <le...@gmail.com> wrote:
>> >
>> > This was a brand new directory. I did choose to install emsdk here
>> instead of somewhere else. I wasn't sure where else to put it. Not sure
>> about the others.
>> >
>> > On Fri, Dec 13, 2024 at 4:08 PM Alexander Saydakov
>> <sa...@yahooinc.com.invalid> wrote:
>> >>
>> >> I am not aware of 'emsdk' and 'includes'. Perhaps those are in your
>> own environment?
>> >> We can remove the .zip after extraction. That would be a slight change
>> to Makefile.
>> >> workflow_settings.yaml is not in version control. I think it is a
>> temporary file, side effect of running some cloud utils.
>> >>
>> >> On Fri, Dec 13, 2024 at 3:55 PM Lee Rhodes <le...@gmail.com> wrote:
>> >>>
>> >>> +1(binding)
>> >>>
>> >>> Whew! I made it through all the way to "make test" and everything
>> passed!
>> >>>
>> >>> I have a couple of minor comments, which should not impact the
>> release:
>> >>>
>> >>> In the README.md file there needs to be a blank line prior to "```
>> .... ```" blocks. Although these blocks rendered ok in Chrome, these
>> blocks may not render in all browsers. I use MacDown to check these kinds
>> of formatting issues.
>> >>> The root directory is looking messy with all of the build related
>> stuff in it. The user's attention should be focused on the sketch
>> directories and the following directories and files distract from that:
>> >>>
>> >>> CICD/
>> >>> datasketches-cpp/ (sym-link)
>> >>> datasketches-cpp-5.1.0/
>> >>> emsdk/
>> >>> includes/
>> >>> cloudbuild.yaml
>> >>> datasketches-cpp-5.1.0.zip
>> >>> readme_generator.py
>> >>> substitute_and_run.sh
>> >>> workflow_settings.yaml
>> >>>
>> >>> Can most of this stuff be put in a "build" directory?
>> >>>
>> >>>
>> >>>
>> >>> On Wed, Dec 11, 2024 at 2:20 PM Alexander Saydakov
>> <sa...@yahooinc.com.invalid> wrote:
>> >>>>
>> >>>> Hello Apache DataSketches PMC and Community,
>> >>>>
>> >>>>
>> >>>> This is a call for vote to release Apache DataSketches-bigquery
>> candidate version 1.0.0-rc1
>> >>>>
>> >>>>
>> >>>> Apache DataSketches library functions for Google BigQuery.
>> >>>>
>> >>>> This is the first release of the product.
>> >>>>
>> >>>> Source repository:
>> >>>>
>> >>>> -
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZHb5mLcs$
>> >>>>
>> >>>>
>> >>>> Git Tag for this release:
>> >>>>
>> >>>> -
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZCyKNNWP$
>> on branch 1.0.x
>> >>>>
>> >>>>
>> >>>> Git HashId for this release is:
>> 407ae7519e10b3f8e5965cad2c9de5475a8bb444
>> >>>>
>> >>>> The Release Candidate Zip Repository:
>> >>>>
>> >>>> -
>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZKuYk3pp$
>> >>>>
>> >>>>
>> >>>> The public signing key can be found in the KEYS file:
>> >>>>
>> >>>> -
>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZExE8xqU$
>> >>>>
>> >>>>
>> >>>>
>> >>>> The artifacts have been signed with key:
>> >>>>
>> >>>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING
>> KEY) <al...@apache.org>
>> >>>>
>> >>>>
>> >>>> Build & Test Guide:
>> >>>>
>> >>>> -
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZDoEZmhn$
>> >>>>
>> >>>>
>> >>>> The vote will be performed as follows:
>> >>>>
>> >>>> - This letter will be published on dev@ and remain open for at
>> least 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
>> community can vote.
>> >>>>
>> >>>>
>> >>>> Please vote accordingly:
>> >>>>
>> >>>>
>> >>>> [ ] +1 approve
>> >>>>
>> >>>> [ ] +0 no opinion
>> >>>>
>> >>>> [ ] -1 disapprove with the reason
>> >>>>
>> >>>>
>> >>>> Thank you,
>> >>>>
>> >>>> Alexander Saydakov
>> >>>>
>> >>>> alsay@apache.org
>> >>>>
>> >>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
>> For additional commands, e-mail: dev-help@datasketches.apache.org
>>
>>
Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1
Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
+1
- checked GPG signature and SHA512
- LICENSE and NOTICE look good
- 'make', 'make install', 'make test' successful
On Mon, Dec 16, 2024 at 3:45 PM Jon Malkin <jo...@gmail.com> wrote:
> +1 (binding)
>
> I checked:
> - checksum + signature
> - make/make install/make test worked
> - LICENSE and NOTICE look good
>
> I don't have any particular problem with the current directory
> structure. I think the general expectation is that few people will
> interact with the raw git repo as opposed to using the sketches, and
> the website and documentation surfaced through BigQuery will matter
> more for usage help.
>
> jon
>
> On Fri, Dec 13, 2024 at 4:17 PM Lee Rhodes <le...@gmail.com> wrote:
> >
> > This was a brand new directory. I did choose to install emsdk here
> instead of somewhere else. I wasn't sure where else to put it. Not sure
> about the others.
> >
> > On Fri, Dec 13, 2024 at 4:08 PM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
> >>
> >> I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own
> environment?
> >> We can remove the .zip after extraction. That would be a slight change
> to Makefile.
> >> workflow_settings.yaml is not in version control. I think it is a
> temporary file, side effect of running some cloud utils.
> >>
> >> On Fri, Dec 13, 2024 at 3:55 PM Lee Rhodes <le...@gmail.com> wrote:
> >>>
> >>> +1(binding)
> >>>
> >>> Whew! I made it through all the way to "make test" and everything
> passed!
> >>>
> >>> I have a couple of minor comments, which should not impact the release:
> >>>
> >>> In the README.md file there needs to be a blank line prior to "```
> .... ```" blocks. Although these blocks rendered ok in Chrome, these
> blocks may not render in all browsers. I use MacDown to check these kinds
> of formatting issues.
> >>> The root directory is looking messy with all of the build related
> stuff in it. The user's attention should be focused on the sketch
> directories and the following directories and files distract from that:
> >>>
> >>> CICD/
> >>> datasketches-cpp/ (sym-link)
> >>> datasketches-cpp-5.1.0/
> >>> emsdk/
> >>> includes/
> >>> cloudbuild.yaml
> >>> datasketches-cpp-5.1.0.zip
> >>> readme_generator.py
> >>> substitute_and_run.sh
> >>> workflow_settings.yaml
> >>>
> >>> Can most of this stuff be put in a "build" directory?
> >>>
> >>>
> >>>
> >>> On Wed, Dec 11, 2024 at 2:20 PM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
> >>>>
> >>>> Hello Apache DataSketches PMC and Community,
> >>>>
> >>>>
> >>>> This is a call for vote to release Apache DataSketches-bigquery
> candidate version 1.0.0-rc1
> >>>>
> >>>>
> >>>> Apache DataSketches library functions for Google BigQuery.
> >>>>
> >>>> This is the first release of the product.
> >>>>
> >>>> Source repository:
> >>>>
> >>>> -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZHb5mLcs$
> >>>>
> >>>>
> >>>> Git Tag for this release:
> >>>>
> >>>> -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZCyKNNWP$
> on branch 1.0.x
> >>>>
> >>>>
> >>>> Git HashId for this release is:
> 407ae7519e10b3f8e5965cad2c9de5475a8bb444
> >>>>
> >>>> The Release Candidate Zip Repository:
> >>>>
> >>>> -
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZKuYk3pp$
> >>>>
> >>>>
> >>>> The public signing key can be found in the KEYS file:
> >>>>
> >>>> -
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZExE8xqU$
> >>>>
> >>>>
> >>>>
> >>>> The artifacts have been signed with key:
> >>>>
> >>>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING
> KEY) <al...@apache.org>
> >>>>
> >>>>
> >>>> Build & Test Guide:
> >>>>
> >>>> -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!F-Jp_F_xh8donPPvH6QWrWRcW3C2SBbehSu5p5nQCgcBGTgnJSVFycHSbJlg7YA7i84AU7iVQcjPZDoEZmhn$
> >>>>
> >>>>
> >>>> The vote will be performed as follows:
> >>>>
> >>>> - This letter will be published on dev@ and remain open for at
> least 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
> community can vote.
> >>>>
> >>>>
> >>>> Please vote accordingly:
> >>>>
> >>>>
> >>>> [ ] +1 approve
> >>>>
> >>>> [ ] +0 no opinion
> >>>>
> >>>> [ ] -1 disapprove with the reason
> >>>>
> >>>>
> >>>> Thank you,
> >>>>
> >>>> Alexander Saydakov
> >>>>
> >>>> alsay@apache.org
> >>>>
> >>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>
Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1
Posted by Jon Malkin <jo...@gmail.com>.
+1 (binding)
I checked:
- checksum + signature
- make/make install/make test worked
- LICENSE and NOTICE look good
I don't have any particular problem with the current directory
structure. I think the general expectation is that few people will
interact with the raw git repo as opposed to using the sketches, and
the website and documentation surfaced through BigQuery will matter
more for usage help.
jon
On Fri, Dec 13, 2024 at 4:17 PM Lee Rhodes <le...@gmail.com> wrote:
>
> This was a brand new directory. I did choose to install emsdk here instead of somewhere else. I wasn't sure where else to put it. Not sure about the others.
>
> On Fri, Dec 13, 2024 at 4:08 PM Alexander Saydakov <sa...@yahooinc.com.invalid> wrote:
>>
>> I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own environment?
>> We can remove the .zip after extraction. That would be a slight change to Makefile.
>> workflow_settings.yaml is not in version control. I think it is a temporary file, side effect of running some cloud utils.
>>
>> On Fri, Dec 13, 2024 at 3:55 PM Lee Rhodes <le...@gmail.com> wrote:
>>>
>>> +1(binding)
>>>
>>> Whew! I made it through all the way to "make test" and everything passed!
>>>
>>> I have a couple of minor comments, which should not impact the release:
>>>
>>> In the README.md file there needs to be a blank line prior to "``` .... ```" blocks. Although these blocks rendered ok in Chrome, these blocks may not render in all browsers. I use MacDown to check these kinds of formatting issues.
>>> The root directory is looking messy with all of the build related stuff in it. The user's attention should be focused on the sketch directories and the following directories and files distract from that:
>>>
>>> CICD/
>>> datasketches-cpp/ (sym-link)
>>> datasketches-cpp-5.1.0/
>>> emsdk/
>>> includes/
>>> cloudbuild.yaml
>>> datasketches-cpp-5.1.0.zip
>>> readme_generator.py
>>> substitute_and_run.sh
>>> workflow_settings.yaml
>>>
>>> Can most of this stuff be put in a "build" directory?
>>>
>>>
>>>
>>> On Wed, Dec 11, 2024 at 2:20 PM Alexander Saydakov <sa...@yahooinc.com.invalid> wrote:
>>>>
>>>> Hello Apache DataSketches PMC and Community,
>>>>
>>>>
>>>> This is a call for vote to release Apache DataSketches-bigquery candidate version 1.0.0-rc1
>>>>
>>>>
>>>> Apache DataSketches library functions for Google BigQuery.
>>>>
>>>> This is the first release of the product.
>>>>
>>>> Source repository:
>>>>
>>>> - https://github.com/apache/datasketches-bigquery
>>>>
>>>>
>>>> Git Tag for this release:
>>>>
>>>> - https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1 on branch 1.0.x
>>>>
>>>>
>>>> Git HashId for this release is: 407ae7519e10b3f8e5965cad2c9de5475a8bb444
>>>>
>>>> The Release Candidate Zip Repository:
>>>>
>>>> - https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/
>>>>
>>>>
>>>> The public signing key can be found in the KEYS file:
>>>>
>>>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>>>>
>>>>
>>>>
>>>> The artifacts have been signed with key:
>>>>
>>>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <al...@apache.org>
>>>>
>>>>
>>>> Build & Test Guide:
>>>>
>>>> - https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md
>>>>
>>>>
>>>> The vote will be performed as follows:
>>>>
>>>> - This letter will be published on dev@ and remain open for at least 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the community can vote.
>>>>
>>>>
>>>> Please vote accordingly:
>>>>
>>>>
>>>> [ ] +1 approve
>>>>
>>>> [ ] +0 no opinion
>>>>
>>>> [ ] -1 disapprove with the reason
>>>>
>>>>
>>>> Thank you,
>>>>
>>>> Alexander Saydakov
>>>>
>>>> alsay@apache.org
>>>>
>>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1
Posted by Lee Rhodes <le...@gmail.com>.
This was a brand new directory. I did choose to install emsdk here instead
of somewhere else. I wasn't sure where else to put it. Not sure about
the others.
On Fri, Dec 13, 2024 at 4:08 PM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own
> environment?
> We can remove the .zip after extraction. That would be a slight change to
> Makefile.
> workflow_settings.yaml is not in version control. I think it is a
> temporary file, side effect of running some cloud utils.
>
> On Fri, Dec 13, 2024 at 3:55 PM Lee Rhodes <le...@gmail.com> wrote:
>
>> +1(binding)
>>
>> Whew! I made it through all the way to "make test" and everything passed!
>>
>> I have a couple of minor comments, which should not impact the release:
>>
>> - In the README.md file there needs to be a blank line prior to "```
>> .... ```" blocks. Although these blocks rendered ok in Chrome, these
>> blocks may not render in all browsers. I use MacDown to check these kinds
>> of formatting issues.
>> - The root directory is looking messy with all of the build related
>> stuff in it. The user's attention should be focused on the sketch
>> directories and the following directories and files distract from that:
>> - CICD/
>> - datasketches-cpp/ (sym-link)
>> - datasketches-cpp-5.1.0/
>> - emsdk/
>> - includes/
>> - cloudbuild.yaml
>> - datasketches-cpp-5.1.0.zip
>> - readme_generator.py
>> - substitute_and_run.sh
>> - workflow_settings.yaml
>>
>> Can most of this stuff be put in a "build" directory?
>>
>>
>>
>> On Wed, Dec 11, 2024 at 2:20 PM Alexander Saydakov
>> <sa...@yahooinc.com.invalid> wrote:
>>
>>> Hello Apache DataSketches PMC and Community,
>>>
>>>
>>> This is a call for vote to release
>>> Apache DataSketches-bigquery candidate version 1.0.0-rc1
>>>
>>> Apache DataSketches library functions for Google BigQuery.
>>>
>>> This is the first release of the product.
>>>
>>> Source repository:
>>>
>>> - https://github.com/apache/datasketches-bigquery
>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDkts3l-n_iU$>
>>>
>>>
>>> Git Tag for this release:
>>>
>>> -
>>> https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1
>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.0.0-rc1__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDktsTs6TUPo$> on
>>> branch 1.0.x
>>>
>>>
>>> Git HashId for this release is: 407ae7519e10b3f8e5965cad2c9de5475a8bb444
>>>
>>> The Release Candidate Zip Repository:
>>>
>>> -
>>> https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/
>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.0-rc1/__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDktsG43CGGo$>
>>>
>>>
>>> The public signing key can be found in the KEYS file:
>>>
>>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>>>
>>>
>>>
>>> The artifacts have been signed with key:
>>>
>>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>>> alsay@apache.org>
>>>
>>>
>>> Build & Test Guide:
>>>
>>> -
>>> https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md
>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!AnY4Pi1izrh83j8zi_gHp0vtxpWq9YrsOABj4toIB2ejpy2Rn_YULJeRnWw05qwUu8CWDkts_CSTMpg$>
>>>
>>>
>>> The vote will be performed as follows:
>>>
>>> - This letter will be published on dev@ and remain open for at least
>>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>>> votes or a majority of (+1) PMC votes are acquired. Anyone in the
>>> community can vote.
>>>
>>>
>>> Please vote accordingly:
>>>
>>>
>>> [ ] +1 approve
>>>
>>> [ ] +0 no opinion
>>>
>>> [ ] -1 disapprove with the reason
>>>
>>>
>>> Thank you,
>>>
>>> Alexander Saydakov
>>>
>>> alsay@apache.org
>>>
>>>
>>>