You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/12 15:06:03 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
315157973 opened a new pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045
Fixes #4980
### Motivation
Expose an REST endpoint to trigger backlogQuotaCheck. That will make integration tests easier in future without forcing it to sleep and wait the block to kick in backlog quota check.
### Modifications
Expose an REST endpoint
### Verifying this change
unit test
org.apache.pulsar.broker.service.BacklogQuotaManagerTest#testTriggerBacklogQuotaWithReader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045#issuecomment-692591397
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045#issuecomment-691574847
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045#issuecomment-691582262
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045#discussion_r488434094
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
##########
@@ -255,6 +256,26 @@ public InternalConfigurationData getInternalConfigurationData() {
return pulsar().getInternalConfigurationData();
}
+ @GET
+ @Path("/backlogQuotaCheck")
Review comment:
I don't think we use CamelCase for naming the endpoint. We can rename it to `/backlog-quota-check`.
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java
##########
@@ -69,6 +69,7 @@ public void testDuplicationApi() throws Exception {
assertNull(enabled);
admin.topics().enableDeduplication(topicName, true);
+ Thread.sleep(1000);
Review comment:
why do we need to add `sleep` here?
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -135,5 +146,6 @@ public CmdBrokers(PulsarAdmin admin) {
jcommander.addCommand("get-internal-config", new GetInternalConfigurationCmd());
jcommander.addCommand("get-runtime-config", new GetRuntimeConfigCmd());
jcommander.addCommand("healthcheck", new HealthcheckCmd());
+ jcommander.addCommand("backlogQuotaCheck", new BacklogQuotaCheckCmd());
Review comment:
same comment as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045#issuecomment-693788211
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8045: Add an REST endpoint to trigger backlogQuotaCheck
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8045:
URL: https://github.com/apache/pulsar/pull/8045
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org