You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by rjbriody <gi...@git.apache.org> on 2016/02/18 18:43:31 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
GitHub user rjbriody opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/231
TINKERPOP-1165:Tooling Support: Compile with -parameters
https://issues.apache.org/jira/browse/TINKERPOP-1165
Add -parameters to maven compile args.
This can be manually verified w/ something like this
```
System.out.println(GraphTraversal.class.getDeclaredMethods()[0].getParameters()[0].getName());
```
Used to print "arg0". Should now print "column".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rjbriody/incubator-tinkerpop TINKERPOP-1165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 79be3f85e0732fa819fa0bea8ff4c5597f925f0e
Author: rjbriody <bo...@datastax.com>
Date: 2016-02-18T17:40:57Z
Add -parameters to compile args.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-187277243
@rjbriody can you please re-target this PR a the `tp31` branch instead of `master`? i'll merge it as soon as you do...sorry didn't notice that until today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by rjbriody <gi...@git.apache.org>.
Github user rjbriody commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-187706244
@spmallette https://github.com/apache/incubator-tinkerpop/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by rjbriody <gi...@git.apache.org>.
Github user rjbriody commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-187281734
I can do that. Will you then take care of merging the necessary tp31 changes to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-186252318
Thanks @zackurey - appreciate that added information. I'm going to just float this PR on the dev mailing list to make sure folks are aware of it. If no objections, we'll go ahead and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by rjbriody <gi...@git.apache.org>.
Github user rjbriody closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-185889471
Any idea of what side-effects this produces? I guess I'm trying to get at what the negative aspects of this configuration might be (having never used this configuration before).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by zackurey <gi...@git.apache.org>.
Github user zackurey commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-185905949
@spmallette Off the top of my head:
1. Maybe security through obfuscation? But this is a open source library and one can easily know which method does what based on matching the version of the library with the type signatures
2. This will make class files a little larger since before Java8 only the method signature was stored. Also this does appear to only be supported by Java8, which is fine since Tinkerpop requires it: https://docs.oracle.com/javase/8/docs/technotes/tools/windows/javac.html. Note, not there for Java7.
I do see some mention of the larger memory footprint issue here: http://docs.oracle.com/javase/tutorial/reflect/member/methodparameterreflection.html. So that is a consideration. In this case, with gremlin-core the difference seems to be about 1K when looking at the uncompressed class file size difference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1165:Tooling Support: ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/231#issuecomment-187281946
yes - i will merge that down to master - no problem there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---