You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/30 20:52:12 UTC

svn commit: r1776640 - in /jmeter/trunk/src/core/org/apache/jmeter/gui/action: RawTextSearcher.java RegexpSearcher.java

Author: pmouawad
Date: Fri Dec 30 20:52:12 2016
New Revision: 1776640

URL: http://svn.apache.org/viewvc?rev=1776640&view=rev
Log:
Sonar : Remove useless assignment

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/RawTextSearcher.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/RegexpSearcher.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/RawTextSearcher.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/RawTextSearcher.java?rev=1776640&r1=1776639&r2=1776640&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/action/RawTextSearcher.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/RawTextSearcher.java Fri Dec 30 20:52:12 2016
@@ -50,7 +50,7 @@ public class RawTextSearcher implements
      */
     @Override
     public boolean search(List<String> textTokens) {
-        boolean result = false;
+        boolean result;
         for (String searchableToken : textTokens) {
             if(!StringUtils.isEmpty(searchableToken)) {
                 if(caseSensitive) {

Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/RegexpSearcher.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/RegexpSearcher.java?rev=1776640&r1=1776639&r2=1776640&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/action/RegexpSearcher.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/RegexpSearcher.java Fri Dec 30 20:52:12 2016
@@ -55,12 +55,9 @@ public class RegexpSearcher implements S
     public boolean search(List<String> textTokens) {
         for (String searchableToken : textTokens) {
             if(!StringUtils.isEmpty(searchableToken)) {
-                Matcher matcher = null;
-                if(caseSensitive) {
-                    matcher = pattern.matcher(searchableToken);
-                } else {
-                    matcher = pattern.matcher(searchableToken.toLowerCase());
-                }
+                Matcher matcher = caseSensitive ? 
+                    pattern.matcher(searchableToken) : 
+                    pattern.matcher(searchableToken.toLowerCase());
                 if(matcher.find()) {
                     return true;
                 }