[GitHub] [lucenenet] NightOwl888 opened a new pull request #321: Fix for analysis culture sensitivity and surrogate pair support

[GitBox <gi...@apache.org>]

NightOwl888 opened a new pull request #321:
URL: https://github.com/apache/lucenenet/pull/321


   This fixes several Analysis.Common classes that were broken since 4.8.0-beta00008 in commit https://github.com/apache/lucenenet/commit/b733c4d158e5e1de62c6b12797c589ac70b4c1c7 because the `Character` class was changed to J2N which uses the current culture by default instead of Java's default of invariant culture for uppercasing and lowercasing. As a result, these classes were unintentionally modified in behavior. This patch reverts them back to the invariant culture (or specific culture for the class, where applicable).
   
   Also, a bug was discovered where a cast from `int` to `char` caused many analysis classes to incorrectly process surrogate pairs, which this addresses.
   
   We were also able to revert the `TurkishLowercaseFilter` back to its original implementation by utilizing `J2N.Character` to do the heavy lifting instead of `System.Char`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #321: Fix for analysis culture sensitivity and surrogate pair support

[GitBox <gi...@apache.org>]

NightOwl888 merged pull request #321:
URL: https://github.com/apache/lucenenet/pull/321


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org