You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "LiZhenNet (GitHub)" <gi...@apache.org> on 2018/12/04 03:19:00 UTC
[GitHub] [incubator-dubbo] LiZhenNet opened issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
- [x] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.6.2
* Operating System version: mac os
* Java version: 1.8
### Steps to reproduce this issue
com.alibaba.dubbo.common.Constants#DEFAULT_SERVER_SHUTDOWN_TIMEOUT，
I think this number is too big，2~3 second is enough。
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> I agree with what you said. But personally think that the difference between fast closing and slow closing is not very big.
> Should we modify it? Maybe. @zonghaishang Can u give some ideas?
I have pull a request to talk about it https://github.com/apache/incubator-dubbo/pull/2901
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ issue closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Can u give some reason?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Since this sleep occurs when the service goes offline, what problems will it cause when you sleep longer?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> Can u give some reason?
> 10 seconds is an insurance time. If you think 10s is too big, please adjust dubbo.service.shutdown.wait
I know it can change value by change the dubbo.service.shutdown.wait, But, 10 second is not a appropriate value.
In 2.5.x , it will sleep 10 second between Registry destroy and Protocol
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@LiZhenNet I've already merge #2901
For the particular issue against com.alibaba.dubbo.common.Constants#DEFAULT_SERVER_SHUTDOWN_TIMEOUT, it is unnecessary any longer to sleep 10 second between Registry destroy and Protocol. Ps. verify.
If you still have confusion on this, pls. send email to dev@dubbo.apache.org and ask @yuyijq to give more comments.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
I agree with what you said. But personally think that the difference between fast closing and slow closing is not very big.
Should we modify it? Maybe. @zonghaishang Can u give some ideas?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
In my opinion, the difference between 10s or 5s is not very big. I can't decide which is better. Each has its own advantages and disadvantages. 5s is better? maybe.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Can u give some reason?
10 seconds is an insurance time. If you think 10s is too big, please adjust dubbo.service.shutdown.wait
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #2877: DEFAULT_SERVER_SHUTDOWN_TIMEOUT，This number is too big
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> In my opinion, the difference between 10s or 5s is not very big. I can't decide which is better. Each has its own advantages and disadvantages. 5s is better? maybe.
It will make the application shutdown slow in old version。
This config in 2.6.x ，it's role that make the request which is excuting return success. In general, a request should not execute more than 5 seconds。
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org