[GitHub] [flink] snuyanzin opened a new pull request, #21087: [hotfix] Use getParameterCount rather than getParameterTypes().length

[GitBox <gi...@apache.org>]

snuyanzin opened a new pull request, #21087:
URL: https://github.com/apache/flink/pull/21087

   ## What is the purpose of the change
   
   Since jdk1.8+ there is `Method#getParameterCount` which allows to get number of parameters. 
   In several places `Method#getParametersTypes` is used for that like `getParameterTypes().length`
   The issue with `Method#getParametersTypes` is that during each invocation it creates a new array by cloning an existing one.
   The PR is replacing  `getParameterTypes().length` with  `Method#getParameterCount` 
   
   ## Brief change log
   
   Replacement of  `getParameterTypes().length` with  `Method#getParameterCount` 
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes )
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
     - The S3 file system connector: (no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21087: [hotfix] Use getParameterCount rather than getParameterTypes().length

[GitBox <gi...@apache.org>]

flinkbot commented on PR #21087:
URL: https://github.com/apache/flink/pull/21087#issuecomment-1280734385

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe82e298873adbc2e2d2a0932cad19a260f27bbc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fe82e298873adbc2e2d2a0932cad19a260f27bbc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe82e298873adbc2e2d2a0932cad19a260f27bbc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #21087: [hotfix] Use getParameterCount rather than getParameterTypes().length

[GitBox <gi...@apache.org>]

zentol merged PR #21087:
URL: https://github.com/apache/flink/pull/21087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org