You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/04/23 00:01:16 UTC

Review Request 20580: Fixed flaky test ReservationAllocatorTest.ResourcesReturned.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20580/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-743
    https://issues.apache.org/jira/browse/MESOS-743


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 

Diff: https://reviews.apache.org/r/20580/diff/


Testing
-------

./bin/mesos-tests.sh --verbose --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 --gtest_break_on_failure


Thanks,

Jiang Yan Xu

Re: Review Request 20580: Fixed flaky test ReservationAllocatorTest.ResourcesReturned.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20580/#review41082
-----------------------------------------------------------

Ship it!



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/20580/#comment74479>

    We try not to reuse the futures.
    
    So call this Future<Nothing> slaveAdded2 and the above one slaveAdded1;


- Vinod Kone


On April 22, 2014, 10:32 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20580/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 10:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-743
>     https://issues.apache.org/jira/browse/MESOS-743
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> In this test, expectation for slaveAdded being called for 'slave2' was set but never waited on. So the test could run to completion without slave2 being registered and added to allocator and thus fail the expectation.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 
> 
> Diff: https://reviews.apache.org/r/20580/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --verbose --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 20580: Fixed flaky test ReservationAllocatorTest.ResourcesReturned.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20580/
-----------------------------------------------------------

(Updated April 22, 2014, 3:50 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

NNFR.


Bugs: MESOS-743
    https://issues.apache.org/jira/browse/MESOS-743


Repository: mesos-git


Description
-------

In this test, expectation for slaveAdded being called for 'slave2' was set but never waited on. So the test could run to completion without slave2 being registered and added to allocator and thus fail the expectation.


Diffs (updated)
-----

  src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 

Diff: https://reviews.apache.org/r/20580/diff/


Testing
-------

./bin/mesos-tests.sh --verbose --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 --gtest_break_on_failure


Thanks,

Jiang Yan Xu

Re: Review Request 20580: Fixed flaky test ReservationAllocatorTest.ResourcesReturned.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20580/
-----------------------------------------------------------

(Updated April 22, 2014, 3:32 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Comments.


Bugs: MESOS-743
    https://issues.apache.org/jira/browse/MESOS-743


Repository: mesos-git


Description (updated)
-------

In this test, expectation for slaveAdded being called for 'slave2' was set but never waited on. So the test could run to completion without slave2 being registered and added to allocator and thus fail the expectation.


Diffs (updated)
-----

  src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 

Diff: https://reviews.apache.org/r/20580/diff/


Testing
-------

./bin/mesos-tests.sh --verbose --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 --gtest_break_on_failure


Thanks,

Jiang Yan Xu

Re: Review Request 20580: Fixed flaky test ReservationAllocatorTest.ResourcesReturned.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20580/#review41081
-----------------------------------------------------------


Can you also explain in the description what the bug was?


src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/20580/#comment74473>

    shouldn't this expectation be set before the slave is added?



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/20580/#comment74474>

    ditto.


- Vinod Kone


On April 22, 2014, 10:01 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20580/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 10:01 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-743
>     https://issues.apache.org/jira/browse/MESOS-743
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 
> 
> Diff: https://reviews.apache.org/r/20580/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --verbose --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>