[GitHub] incubator-weex pull request #501: [iOS] fix WXCycleSliderComponent initial i...

[kfeagle <gi...@git.apache.org>]

Github user kfeagle commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/501#discussion_r126387701
  
    --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCycleSliderComponent.m ---
    @@ -460,6 +460,12 @@ - (void)insertSubview:(WXComponent *)subcomponent atIndex:(NSInteger)index
                     }
                 }
                 [recycleSliderView insertItemView:view atIndex:index - offset];
    +            
    +            // check if should apply current contentOffset
    +            // in case inserting subviews after layoutDidFinish
    +            if (index-offset == _index) {
    --- End diff --
    
    _index > 0 is it better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---