You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/16 12:29:41 UTC
[GitHub] [beam] masahitojp opened a new pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
masahitojp opened a new pull request #13994:
URL: https://github.com/apache/beam/pull/13994
bump google-cloud-pubsub to 1.111.0
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-781261547
@suztomo Thank you for your great contribution!!
> It seems that proto-google-cloud-pubsub-v1 needs to have a newer version. Would you check it?
I checked it. I can't say anything, but I think it's preferable to update it
https://github.com/apache/beam/blob/b8dd9cb4dfbcacda3b50baa440a0f3642b230990/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L607
maybe , In other words, I think it will affect this trend.
> Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks.
I think it would be good to put it on hold until this work is finished. 😢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (04f0e2c) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58298
==========================================
- Hits 48379 48373 -6
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...7110874](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (04f0e2c) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 469 469
Lines 58298 58298
=======================================
+ Hits 48372 48373 +1
+ Misses 9926 9925 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...04f0e2c](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780673295
I tried and got the same error. Digging further. https://gist.github.com/suztomo/b5a33361ad83c5e5c9054b393ac496c1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-781261547
@suztomo Thank you for your great contribution!!
> It seems that proto-google-cloud-pubsub-v1 needs to have a newer version. Would you check it?
I checked it. I can't say anything, but I think it's preferable to update it
https://github.com/apache/beam/blob/b8dd9cb4dfbcacda3b50baa440a0f3642b230990/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L607
> // google_cloud_platform_libraries_bom sets version
maybe , In other words, I think it will affect this.....
> Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks.
I think it would be good to put it on hold until this work is finished. 😢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780501401
Hi @suztomo
I tried the command.
> sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
but I got a below errors :cry:
```
Failed to generate the baseline file. Check the build error above.
Checking linkage for origin/beam-11770
Previous HEAD position was 3930d12d47 Merge pull request #13981: [BEAM-11124] bump joda-time to 2.10.10
HEAD is now at 45ba4c5888 [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Running linkage check (validate) for beam-sdks-java-core
using baseline build/linkagecheck/baseline-beam-sdks-java-core.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-google-cloud-platform
using baseline build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
Error: Baseline file not found
Running linkage check (validate) for beam-runners-google-cloud-dataflow-java
using baseline build/linkagecheck/baseline-beam-runners-google-cloud-dataflow-java.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-hadoop-format
using baseline build/linkagecheck/baseline-beam-sdks-java-io-hadoop-format.xml
Error: Baseline file not found
```
In the previous jobs, it is displayed as "BUILD SUCCESSFUL ".
Do you know what is causing it? (Manjaro Linux + openjdk version "1.8.0_282")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780150963
Run Java Postcommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (04f0e2c) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 469 469
Lines 58298 58298
=======================================
+ Hits 48372 48373 +1
+ Misses 9926 9925 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...04f0e2c](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780806857
@masahitojp It seems that beam-linkage-check.sh has not been migrated properly when this repository moved build script from Gradle to Kotlin. (Your observation helped me to identify the problem. Thank you!)
I raised a pull request to fix the problem https://github.com/apache/beam/pull/14006. Give me and Beam committers some moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (df3fd10) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.01%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48375 -4
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==) | | |
| [...hon/apache\_beam/examples/complete/game/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9fX2luaXRfXy5weQ==) | | |
| [.../apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | | |
| [...apache\_beam/typehints/native\_type\_compatibility.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL25hdGl2ZV90eXBlX2NvbXBhdGliaWxpdHkucHk=) | | |
| [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | | |
| [...\_beam/runners/interactive/user\_pipeline\_tracker.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91c2VyX3BpcGVsaW5lX3RyYWNrZXIucHk=) | | |
| [sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | | |
| [...ks/python/apache\_beam/runners/worker/operations.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3BlcmF0aW9ucy5weQ==) | | |
| [.../examples/snippets/transforms/elementwise/regex.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9yZWdleC5weQ==) | | |
| [...python/apache\_beam/typehints/typehints\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3R5cGVoaW50c190ZXN0X3B5My5weQ==) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780866502
@masahitojp I rebased your branch and ran the tool
https://gist.github.com/suztomo/0ba02d93aa0b2f5d9701c50f7d7fd81f It seems that proto-google-cloud-pubsub-v1 needs to have a newer version. Would you check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (7110874) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48374 -5
- Misses 9919 9926 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | | |
| [...dks/python/apache\_beam/io/gcp/internal/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL19faW5pdF9fLnB5) | | |
| [sdks/python/apache\_beam/ml/gcp/visionml\_test\_it.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL3Zpc2lvbm1sX3Rlc3RfaXQucHk=) | | |
| [sdks/python/apache\_beam/utils/processes.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvY2Vzc2VzLnB5) | | |
| [...nternal/clients/dataflow/dataflow\_v1b3\_messages.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L2RhdGFmbG93X3YxYjNfbWVzc2FnZXMucHk=) | | |
| [sdks/python/apache\_beam/io/vcfio.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdmNmaW8ucHk=) | | |
| [...m/testing/benchmarks/nexmark/models/auction\_bid.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL2F1Y3Rpb25fYmlkLnB5) | | |
| [sdks/python/apache\_beam/utils/sharded\_key.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmRlZF9rZXkucHk=) | | |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | | |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...7110874](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58298 58343 +45
==========================================
+ Hits 48372 48396 +24
- Misses 9926 9947 +21
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/transforms/stats.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zdGF0cy5weQ==) | `86.72% <0.00%> (-10.62%)` | :arrow_down: |
| [...apache\_beam/portability/api/beam\_runner\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjIucHk=) | `100.00% <0.00%> (ø)` | |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.92% <0.00%> (ø)` | |
| [...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=) | `90.54% <0.00%> (+0.04%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.52% <0.00%> (+0.13%)` | :arrow_up: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (+0.16%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.07% <0.00%> (+0.27%)` | :arrow_up: |
| [...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==) | `80.00% <0.00%> (+0.38%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...04f0e2c](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (7110874) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48374 -5
- Misses 9919 9926 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../gcp/internal/clients/storage/storage\_v1\_client.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvc3RvcmFnZS9zdG9yYWdlX3YxX2NsaWVudC5weQ==) | | |
| [sdks/python/apache\_beam/io/external/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvX19pbml0X18ucHk=) | | |
| [...dks/python/apache\_beam/transforms/external\_java.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9leHRlcm5hbF9qYXZhLnB5) | | |
| [...beam/runners/portability/fn\_api\_runner/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL19faW5pdF9fLnB5) | | |
| [sdks/python/apache\_beam/utils/counters.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvY291bnRlcnMucHk=) | | |
| [...examples/snippets/transforms/aggregation/latest.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9sYXRlc3QucHk=) | | |
| [...on/apache\_beam/io/gcp/bigquery\_io\_read\_pipeline.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2lvX3JlYWRfcGlwZWxpbmUucHk=) | | |
| [sdks/python/apache\_beam/io/gcp/spanner.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3NwYW5uZXIucHk=) | | |
| [sdks/python/apache\_beam/dataframe/transforms.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3RyYW5zZm9ybXMucHk=) | | |
| [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...7110874](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (df3fd10) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.01%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48375 -4
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | | |
| [...ks/python/apache\_beam/runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | | |
| [...e\_beam/portability/api/beam\_runner\_api\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfZ3JwYy5weQ==) | | |
| [...s/snippets/transforms/aggregation/combinevalues.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb21iaW5ldmFsdWVzLnB5) | | |
| [...ython/apache\_beam/io/aws/clients/s3/fake\_client.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvZmFrZV9jbGllbnQucHk=) | | |
| [sdks/python/apache\_beam/transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | | |
| [...dks/python/apache\_beam/runners/pipeline\_context.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9waXBlbGluZV9jb250ZXh0LnB5) | | |
| [...m/testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL21vZGVsLnB5) | | |
| [...python/apache\_beam/typehints/typehints\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3R5cGVoaW50c190ZXN0X3B5My5weQ==) | | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (df3fd10) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.01%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48375 -4
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vX19pbml0X18ucHk=) | | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | | |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | | |
| [...beam/testing/benchmarks/nexmark/models/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL19faW5pdF9fLnB5) | | |
| [...on/apache\_beam/runners/worker/statesampler\_slow.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc3RhdGVzYW1wbGVyX3Nsb3cucHk=) | | |
| [sdks/python/apache\_beam/examples/complete/tfidf.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvdGZpZGYucHk=) | | |
| [...ache\_beam/examples/cookbook/datastore\_wordcount.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svZGF0YXN0b3JlX3dvcmRjb3VudC5weQ==) | | |
| [sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=) | | |
| [...pache\_beam/dataframe/pandas\_top\_level\_functions.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3BhbmRhc190b3BfbGV2ZWxfZnVuY3Rpb25zLnB5) | | |
| [sdks/python/apache\_beam/runners/direct/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdXRpbC5weQ==) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.110.3(google_cloud_platform_libraries_bom )
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13994:
URL: https://github.com/apache/beam/pull/13994#discussion_r581134564
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -527,7 +526,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_cloud_datacatalog_v1beta1 : "com.google.cloud:google-cloud-datacatalog", // google_cloud_platform_libraries_bom sets version
google_cloud_dataflow_java_proto_library_all: "com.google.cloud.dataflow:google-cloud-dataflow-java-proto-library-all:0.5.160304",
google_cloud_datastore_v1_proto_client : "com.google.cloud.datastore:datastore-v1-proto-client:1.6.3",
- google_cloud_pubsub : "com.google.cloud:google-cloud-pubsub:$google_cloud_pubsub_version",
+ google_cloud_pubsub : "com.google.cloud:google-cloud-pubsub", // google_cloud_platform_libraries_bom sets version
Review comment:
+1, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (df3fd10) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.01%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48375 -4
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vX19pbml0X18ucHk=) | | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | | |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | | |
| [...beam/testing/benchmarks/nexmark/models/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL19faW5pdF9fLnB5) | | |
| [...on/apache\_beam/runners/worker/statesampler\_slow.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc3RhdGVzYW1wbGVyX3Nsb3cucHk=) | | |
| [sdks/python/apache\_beam/examples/complete/tfidf.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvdGZpZGYucHk=) | | |
| [...ache\_beam/examples/cookbook/datastore\_wordcount.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svZGF0YXN0b3JlX3dvcmRjb3VudC5weQ==) | | |
| [sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=) | | |
| [...pache\_beam/dataframe/pandas\_top\_level\_functions.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3BhbmRhc190b3BfbGV2ZWxfZnVuY3Rpb25zLnB5) | | |
| [sdks/python/apache\_beam/runners/direct/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdXRpbC5weQ==) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.110.3(google_cloud_platform_libraries_bom )
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #13994:
URL: https://github.com/apache/beam/pull/13994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-783345839
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779875199
R: @iemejia
Could you review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780151743
@masahitojp Would you try running the command below?
```
sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
```
https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades#app-switcher (this has outdated command line parameter. It now takes 2 git branches.)
If there's no new conflict, it looks good to me (I'm not a committer though).
Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks. They might interfere this PR; thank you for your patience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (04f0e2c) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58298
==========================================
- Hits 48379 48373 -6
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.55% <0.00%> (-0.27%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...04f0e2c](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on a change in pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.110.3(google_cloud_platform_libraries_bom )
Posted by GitBox <gi...@apache.org>.
suztomo commented on a change in pull request #13994:
URL: https://github.com/apache/beam/pull/13994#discussion_r581099589
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -527,7 +526,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_cloud_datacatalog_v1beta1 : "com.google.cloud:google-cloud-datacatalog", // google_cloud_platform_libraries_bom sets version
google_cloud_dataflow_java_proto_library_all: "com.google.cloud.dataflow:google-cloud-dataflow-java-proto-library-all:0.5.160304",
google_cloud_datastore_v1_proto_client : "com.google.cloud.datastore:datastore-v1-proto-client:1.6.3",
- google_cloud_pubsub : "com.google.cloud:google-cloud-pubsub:$google_cloud_pubsub_version",
+ google_cloud_pubsub : "com.google.cloud:google-cloud-pubsub", // google_cloud_platform_libraries_bom sets version
Review comment:
This is a nice enhancement. No need to maintain google-cloud-pubsub separately. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780082848
I am not familiar with the consequences of dependency upgrades for Google related dependencies, so in the future for google related dependencies please choose as a reviewer like @kennknowles @chamikaramj or @suztomo
Can someone of you please help review this one or forward this to someone who can. Thanks!
Oh and thanks for your this and all the other recent contributions @masahitojp !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (04f0e2c) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 469 469
Lines 58298 58298
=======================================
+ Hits 48372 48373 +1
+ Misses 9926 9925 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...04f0e2c](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780673295
I tried and got the same error. Digging further. https://gist.github.com/suztomo/b5a33361ad83c5e5c9054b393ac496c1
Created an issue: [BEAM-11827](https://issues.apache.org/jira/browse/BEAM-11827).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (df3fd10) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.01%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48375 -4
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/vcfio.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdmNmaW8ucHk=) | | |
| [sdks/python/apache\_beam/io/kafka.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2Fma2EucHk=) | | |
| [...on/apache\_beam/runners/worker/statesampler\_slow.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc3RhdGVzYW1wbGVyX3Nsb3cucHk=) | | |
| [.../apache\_beam/portability/api/endpoints\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2VuZHBvaW50c19wYjJfZ3JwYy5weQ==) | | |
| [sdks/python/apache\_beam/transforms/trigger.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy90cmlnZ2VyLnB5) | | |
| [...apache\_beam/examples/complete/game/leader\_board.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9sZWFkZXJfYm9hcmQucHk=) | | |
| [sdks/python/apache\_beam/pvalue.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcHZhbHVlLnB5) | | |
| [sdks/python/apache\_beam/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9jZWxscy5weQ==) | | |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | | |
| [sdks/python/apache\_beam/transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780501401
Hi @suztomo
I tried the command.
> sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
but I got a below errors :cry:
```
Failed to generate the baseline file. Check the build error above.
Checking linkage for origin/beam-11770
Previous HEAD position was 3930d12d47 Merge pull request #13981: [BEAM-11124] bump joda-time to 2.10.10
HEAD is now at 45ba4c5888 [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Running linkage check (validate) for beam-sdks-java-core
using baseline build/linkagecheck/baseline-beam-sdks-java-core.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-google-cloud-platform
using baseline build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
Error: Baseline file not found
Running linkage check (validate) for beam-runners-google-cloud-dataflow-java
using baseline build/linkagecheck/baseline-beam-runners-google-cloud-dataflow-java.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-hadoop-format
using baseline build/linkagecheck/baseline-beam-sdks-java-io-hadoop-format.xml
Error: Baseline file not found
```
Do you know what is causing it? (openjdk version "1.8.0_282")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (7110874) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48374 -5
- Misses 9919 9926 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/gcp/json\_value.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2pzb25fdmFsdWUucHk=) | | |
| [...n/apache\_beam/runners/direct/test\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9kaXJlY3RfcnVubmVyLnB5) | | |
| [...ache\_beam/runners/portability/expansion\_service.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9leHBhbnNpb25fc2VydmljZS5weQ==) | | |
| [...snippets/transforms/aggregation/combineglobally.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb21iaW5lZ2xvYmFsbHkucHk=) | | |
| [...he\_beam/transforms/combinefn\_lifecycle\_pipeline.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lZm5fbGlmZWN5Y2xlX3BpcGVsaW5lLnB5) | | |
| [.../python/apache\_beam/examples/windowed\_wordcount.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvd2luZG93ZWRfd29yZGNvdW50LnB5) | | |
| [...hon/apache\_beam/runners/worker/worker\_pool\_main.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3Bvb2xfbWFpbi5weQ==) | | |
| [sdks/python/apache\_beam/io/utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdXRpbHMucHk=) | | |
| [...python/apache\_beam/typehints/typehints\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3R5cGVoaW50c190ZXN0X3B5My5weQ==) | | |
| [...nners/direct/consumer\_tracking\_pipeline\_visitor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvY29uc3VtZXJfdHJhY2tpbmdfcGlwZWxpbmVfdmlzaXRvci5weQ==) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.110.3(google_cloud_platform_libraries_bom )
Posted by GitBox <gi...@apache.org>.
masahitojp commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-784200417
The current master branch depends on 16.3.0 (#13990)
In other words, there was no longer any affect on us.
> Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks.
#13990 is merged, and this PR is restarted, especially since it does not seem to be causing any problems in testing.
----
Now I've changed the purpose of this PR.
## what
> bump google-cloud-pubsub to 1.110.3, because we follwed dependencies in google_cloud_platform_libraries_bom sets version.
The current master branch depends on 16.3.0 (#13990)
https://storage.googleapis.com/cloud-opensource-java-dashboard/com.google.cloud/libraries-bom/16.3.0/artifact_details.html
^ It depends on com.google.cloud:google-cloud-pubsub:1.110.3
Since this is newer than the current master(1.108.6 ) , I think it's better to update
## why(background)
The apache beam specifies the versions of the following packages
* com.google.cloud:google-cloud-pubsub
But this package has dependencies with the following packages but this one is specified by `google_cloud_platform_libraries_bom `
* com.google.api.grpc:proto-google-cloud-pubsub-v1
* com.google.api.grpc:grpc-google-cloud-pubsub-v1
The dependencies of this package are difficult to understand for people who don't know about it, so there is a possibility that the dependencies will be broken unintentionally in the future. For this reason, I thought it would be better for me to unify them into `google_cloud_platform_libraries_bom `
^ It depends on com.google.cloud:google-cloud-pubsub:1.110.3
Since this is newer than the current master(1.108.6 ) , I think it's better to update
## results of sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
Success
https://gist.github.com/masahitojp/6a292e3d8ff5506383fca3a44805bafb
(Thanks to your support @suztomo )
----
Could you re-review this PR?
R: @TheNeuralBit @iemejia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (7110874) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48374 -5
- Misses 9919 9926 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/testing/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9fX2luaXRfXy5weQ==) | | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| [...he\_beam/io/flink/flink\_streaming\_impulse\_source.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmxpbmsvZmxpbmtfc3RyZWFtaW5nX2ltcHVsc2Vfc291cmNlLnB5) | | |
| [...ache\_beam/examples/snippets/transforms/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9fX2luaXRfXy5weQ==) | | |
| [...on/apache\_beam/examples/complete/juliaset/setup.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvc2V0dXAucHk=) | | |
| [sdks/python/apache\_beam/runners/direct/clock.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvY2xvY2sucHk=) | | |
| [...am/examples/complete/juliaset/juliaset/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvX19pbml0X18ucHk=) | | |
| [sdks/python/apache\_beam/io/watermark\_estimators.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vd2F0ZXJtYXJrX2VzdGltYXRvcnMucHk=) | | |
| [...python/apache\_beam/runners/portability/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9fX2luaXRfXy5weQ==) | | |
| [sdks/python/apache\_beam/runners/job/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9qb2IvX19pbml0X18ucHk=) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...7110874](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779839873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780532819
> Check the build error above.
Do you see any error above the line?
On Wed, Feb 17, 2021 at 06:45 Masato Nakamura <no...@github.com>
wrote:
> Hi @suztomo <https://github.com/suztomo>
>
> I tried the command.
>
> sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
>
> but I got a below errors 😢
>
> Failed to generate the baseline file. Check the build error above.
>
> Checking linkage for origin/beam-11770
>
> Previous HEAD position was 3930d12d47 Merge pull request #13981: [BEAM-11124] bump joda-time to 2.10.10
>
> HEAD is now at 45ba4c5888 [BEAM-11770] bump google-cloud-pubsub to 1.111.0
>
> Running linkage check (validate) for beam-sdks-java-core
>
> using baseline build/linkagecheck/baseline-beam-sdks-java-core.xml
>
> Error: Baseline file not found
>
> Running linkage check (validate) for beam-sdks-java-io-google-cloud-platform
>
> using baseline build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
>
> Error: Baseline file not found
>
> Running linkage check (validate) for beam-runners-google-cloud-dataflow-java
>
> using baseline build/linkagecheck/baseline-beam-runners-google-cloud-dataflow-java.xml
>
> Error: Baseline file not found
>
> Running linkage check (validate) for beam-sdks-java-io-hadoop-format
>
> using baseline build/linkagecheck/baseline-beam-sdks-java-io-hadoop-format.xml
>
> Error: Baseline file not found
>
>
> Do you know what is causing it? (openjdk version "1.8.0_282")
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/13994#issuecomment-780501401>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAG7PFWCDCIDIFYKWD4NI3S7OT4TANCNFSM4XWLXX2Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-781261547
@suztomo Thank you for your great contribution!!
> It seems that proto-google-cloud-pubsub-v1 needs to have a newer version. Would you check it?
I checked it. I can't say anything, but I think it's preferable to update it
https://github.com/apache/beam/blob/b8dd9cb4dfbcacda3b50baa440a0f3642b230990/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L607
maybe , In other words, I think it will affect this.....
> Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks.
I think it would be good to put it on hold until this work is finished. 😢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (7110874) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48374 -5
- Misses 9919 9926 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dks/python/apache\_beam/testing/extra\_assertions.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9leHRyYV9hc3NlcnRpb25zLnB5) | | |
| [...ers/dataflow/dataflow\_exercise\_metrics\_pipeline.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19leGVyY2lzZV9tZXRyaWNzX3BpcGVsaW5lLnB5) | | |
| [...dks/python/apache\_beam/transforms/create\_source.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jcmVhdGVfc291cmNlLnB5) | | |
| [sdks/python/apache\_beam/io/avroio.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXZyb2lvLnB5) | | |
| [...ython/apache\_beam/io/external/generate\_sequence.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvZ2VuZXJhdGVfc2VxdWVuY2UucHk=) | | |
| [...hon/apache\_beam/examples/wordcount\_with\_metrics.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvd29yZGNvdW50X3dpdGhfbWV0cmljcy5weQ==) | | |
| [...testing/benchmarks/nexmark/queries/winning\_bids.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy93aW5uaW5nX2JpZHMucHk=) | | |
| [sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaGlzdG9ncmFtLnB5) | | |
| [...ers/dataflow/internal/clients/dataflow/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L19faW5pdF9fLnB5) | | |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...7110874](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (df3fd10) into [master](https://codecov.io/gh/apache/beam/commit/aaad864c9acb22e35050f974a7ac74fb7638f085?el=desc) (aaad864) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.01%
==========================================
Files 469 469
Lines 58298 58300 +2
==========================================
- Hits 48379 48375 -4
- Misses 9919 9925 +6
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...am/portability/api/external\_transforms\_pb2\_grpc.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2V4dGVybmFsX3RyYW5zZm9ybXNfcGIyX2dycGMucHk=) | | |
| [...on/apache\_beam/portability/api/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fam9iX2FwaV9wYjIucHk=) | | |
| [.../examples/snippets/transforms/aggregation/count.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb3VudC5weQ==) | | |
| [...hon/apache\_beam/runners/worker/worker\_pool\_main.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3Bvb2xfbWFpbi5weQ==) | | |
| [...s/python/apache\_beam/typehints/sharded\_key\_type.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NoYXJkZWRfa2V5X3R5cGUucHk=) | | |
| [...am/testing/benchmarks/chicago\_taxi/process\_tfma.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9wcm9jZXNzX3RmbWEucHk=) | | |
| [...\_beam/testing/benchmarks/nexmark/queries/query0.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTAucHk=) | | |
| [...s/python/apache\_beam/runners/worker/log\_handler.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvbG9nX2hhbmRsZXIucHk=) | | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | | |
| [...am/testing/benchmarks/chicago\_taxi/trainer/task.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL3Rhc2sucHk=) | | |
| ... and [928 more](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [aaad864...df3fd10](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-779817199
# [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=h1) Report
> Merging [#13994](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=desc) (45ba4c5) into [master](https://codecov.io/gh/apache/beam/commit/3930d12d47a613458988a7421d789ca1abffa853?el=desc) (3930d12) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13994 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.03%
==========================================
Files 469 469
Lines 58343 58343
==========================================
- Hits 48411 48396 -15
- Misses 9932 9947 +15
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.52% <0.00%> (-1.80%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.73% <0.00%> (-1.36%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.74% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13994/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.66% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=footer). Last update [3930d12...45ba4c5](https://codecov.io/gh/apache/beam/pull/13994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] masahitojp edited a comment on pull request #13994: [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Posted by GitBox <gi...@apache.org>.
masahitojp edited a comment on pull request #13994:
URL: https://github.com/apache/beam/pull/13994#issuecomment-780501401
Hi @suztomo
I tried the command.
> sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770
but I got a below errors :cry:
```
Failed to generate the baseline file. Check the build error above.
Checking linkage for origin/beam-11770
Previous HEAD position was 3930d12d47 Merge pull request #13981: [BEAM-11124] bump joda-time to 2.10.10
HEAD is now at 45ba4c5888 [BEAM-11770] bump google-cloud-pubsub to 1.111.0
Running linkage check (validate) for beam-sdks-java-core
using baseline build/linkagecheck/baseline-beam-sdks-java-core.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-google-cloud-platform
using baseline build/linkagecheck/baseline-beam-sdks-java-io-google-cloud-platform.xml
Error: Baseline file not found
Running linkage check (validate) for beam-runners-google-cloud-dataflow-java
using baseline build/linkagecheck/baseline-beam-runners-google-cloud-dataflow-java.xml
Error: Baseline file not found
Running linkage check (validate) for beam-sdks-java-io-hadoop-format
using baseline build/linkagecheck/baseline-beam-sdks-java-io-hadoop-format.xml
Error: Baseline file not found
```
In the previous jobs, it is displayed as "BUILD SUCCESSFUL ".
Do you know what is causing it? (openjdk version "1.8.0_282")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org