You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Lucas Brutschy <lb...@confluent.io.INVALID> on 2025/02/12 11:12:55 UTC
Re: [VOTE] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics
Hey.
Just a note about KIP-1111: We accepted this KIP, and the main
proposal is a new config which optionally treats any implicitly named
internal topic as fatal. However, the KIP also proposes logging a WARN
message about every topic / internal topic that has an auto-generated
name even when the config is off. This will mean a lot of users will
get these warnings starting with 4.1. I personally missed that detail
when discussing the KIP. I just point it out explicitly, since others
may have missed it as well, and it wasn't really discussed. In
retrospect, I would have objected to the WARN log, as any user
starting with a basic Kafka Streams example will be immediately
confronted with them. But it may be that I am the only one who missed
it, in which case I’m okay with going forward with the KIP as
accepted.
Cheers,
Lucas
On Mon, Dec 16, 2024 at 8:56 AM Sebastien Viale
<se...@michelin.com> wrote:
>
> Hi,
>
> Thanks for voting.
>
> I'll conclude the vote with 5 binding votes from:
> Matthias, Sophie, Bruno, Bill and Lucas.
>
> cheers !
>
> Sébastien
>
> ________________________________
> De : Matthias J. Sax <mj...@apache.org>
> Envoyé : jeudi 12 décembre 2024 22:48
> À : dev@kafka.apache.org <de...@kafka.apache.org>
> Objet : [EXT] Re: [VOTE] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics
>
> Warning External sender Do not click on any links or open any attachments unless you trust the sender and know the content is safe.
>
> +1 (binding)
>
> This email was screened for spam and malicious content but exercise caution anyway.
>
>
>
> On 12/11/24 2:57 PM, Sophie Blee-Goldman wrote:
> > +1 (binding)
> >
> > thanks Sebastien!
> >
> > -Sophie
> >
> > On Tue, Dec 10, 2024 at 9:26 AM Bill Bejeck <bb...@gmail.com> wrote:
> >
> >> Hi Sébastien,
> >>
> >> Thanks for the KIP!
> >>
> >> +1(binding)
> >>
> >> Regards,
> >> Bill
> >>
> >> On Fri, Dec 6, 2024 at 4:33 AM Bruno Cadonna <ca...@apache.org> wrote:
> >>
> >>> Hi Sébastien,
> >>>
> >>> +1 (binding)
> >>>
> >>> Many Thanks!
> >>> Bruno
> >>>
> >>> On 06.12.24 10:13, Lucas Brutschy wrote:
> >>>> Thanks for the KIP!
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>> Cheers,
> >>>> Lucas
> >>>>
> >>>> On Fri, Dec 6, 2024 at 9:41 AM Sebastien Viale
> >>>> <se...@michelin.com> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> I'd like to start the vote on KIP-1111 - Enforcing Explicit Naming for
> >>> Kafka Streams Internal Topics:
> >>>>>
> >>>>>
> >>>
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1111%3A+Enforcing+Explicit+Naming+for+Kafka+Streams+Internal+Topics<https://cwiki.apache.org/confluence/display/KAFKA/KIP-1111%3A+Enforcing+Explicit+Naming+for+Kafka+Streams+Internal+Topics>
> >>>>>
> >>>>> This proposal aims to add a configuration that prevents a Kafka
> >> Streams
> >>> application from starting if any of its internal topics / stores have
> >>> auto-generated names,
> >>>>>
> >>>>> If you have any suggestions or feedback, feel free to participate to
> >>> the discussion thread:
> >>>>>
> >>>>> https://lists.apache.org/thread/k05o50clxtjv0x748sw2wj5jj4389tc0<https://lists.apache.org/thread/k05o50clxtjv0x748sw2wj5jj4389tc0>
> >>>>>
> >>>>> cheers !
> >>>>> Sébastien
> >>>>>
> >>>
> >>>
> >>
> >
Re: [VOTE] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics
Posted by "Matthias J. Sax" <mj...@apache.org>.
Thanks for pointing this out.
I don't have any concerns. Also, even if the KIP make this statement,
logging is usually treated more as an implementation detail. Guess, that
is why I did not pay too much attention to it to begin with.
Thus, if it would really become a problem, we can always just change it
to DEBUG level or even remove it completely at any time from my POV.
-Matthias
On 2/12/25 3:12 AM, Lucas Brutschy wrote:
> Hey.
>
> Just a note about KIP-1111: We accepted this KIP, and the main
> proposal is a new config which optionally treats any implicitly named
> internal topic as fatal. However, the KIP also proposes logging a WARN
> message about every topic / internal topic that has an auto-generated
> name even when the config is off. This will mean a lot of users will
> get these warnings starting with 4.1. I personally missed that detail
> when discussing the KIP. I just point it out explicitly, since others
> may have missed it as well, and it wasn't really discussed. In
> retrospect, I would have objected to the WARN log, as any user
> starting with a basic Kafka Streams example will be immediately
> confronted with them. But it may be that I am the only one who missed
> it, in which case I’m okay with going forward with the KIP as
> accepted.
>
> Cheers,
> Lucas
>
> On Mon, Dec 16, 2024 at 8:56 AM Sebastien Viale
> <se...@michelin.com> wrote:
>>
>> Hi,
>>
>> Thanks for voting.
>>
>> I'll conclude the vote with 5 binding votes from:
>> Matthias, Sophie, Bruno, Bill and Lucas.
>>
>> cheers !
>>
>> Sébastien
>>
>> ________________________________
>> De : Matthias J. Sax <mj...@apache.org>
>> Envoyé : jeudi 12 décembre 2024 22:48
>> À : dev@kafka.apache.org <de...@kafka.apache.org>
>> Objet : [EXT] Re: [VOTE] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics
>>
>> Warning External sender Do not click on any links or open any attachments unless you trust the sender and know the content is safe.
>>
>> +1 (binding)
>>
>> This email was screened for spam and malicious content but exercise caution anyway.
>>
>>
>>
>> On 12/11/24 2:57 PM, Sophie Blee-Goldman wrote:
>>> +1 (binding)
>>>
>>> thanks Sebastien!
>>>
>>> -Sophie
>>>
>>> On Tue, Dec 10, 2024 at 9:26 AM Bill Bejeck <bb...@gmail.com> wrote:
>>>
>>>> Hi Sébastien,
>>>>
>>>> Thanks for the KIP!
>>>>
>>>> +1(binding)
>>>>
>>>> Regards,
>>>> Bill
>>>>
>>>> On Fri, Dec 6, 2024 at 4:33 AM Bruno Cadonna <ca...@apache.org> wrote:
>>>>
>>>>> Hi Sébastien,
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Many Thanks!
>>>>> Bruno
>>>>>
>>>>> On 06.12.24 10:13, Lucas Brutschy wrote:
>>>>>> Thanks for the KIP!
>>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> Cheers,
>>>>>> Lucas
>>>>>>
>>>>>> On Fri, Dec 6, 2024 at 9:41 AM Sebastien Viale
>>>>>> <se...@michelin.com> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I'd like to start the vote on KIP-1111 - Enforcing Explicit Naming for
>>>>> Kafka Streams Internal Topics:
>>>>>>>
>>>>>>>
>>>>>
>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1111%3A+Enforcing+Explicit+Naming+for+Kafka+Streams+Internal+Topics<https://cwiki.apache.org/confluence/display/KAFKA/KIP-1111%3A+Enforcing+Explicit+Naming+for+Kafka+Streams+Internal+Topics>
>>>>>>>
>>>>>>> This proposal aims to add a configuration that prevents a Kafka
>>>> Streams
>>>>> application from starting if any of its internal topics / stores have
>>>>> auto-generated names,
>>>>>>>
>>>>>>> If you have any suggestions or feedback, feel free to participate to
>>>>> the discussion thread:
>>>>>>>
>>>>>>> https://lists.apache.org/thread/k05o50clxtjv0x748sw2wj5jj4389tc0<https://lists.apache.org/thread/k05o50clxtjv0x748sw2wj5jj4389tc0>
>>>>>>>
>>>>>>> cheers !
>>>>>>> Sébastien
>>>>>>>
>>>>>
>>>>>
>>>>
>>>