You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/29 00:26:54 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12697: Refactor airflow plugins command
turbaszek opened a new pull request #12697:
URL: https://github.com/apache/airflow/pull/12697
This commit refactors plugins command to make it more
user-friendly, structured and easier to read.
Before:
<img width="700" alt="Screenshot 2020-11-29 at 01 05 52" src="https://user-images.githubusercontent.com/9528307/100528602-12ee3080-31df-11eb-91b1-eaa24d8eb5f1.png">
After
<img width="700" alt="Screenshot 2020-11-29 at 01 23 23" src="https://user-images.githubusercontent.com/9528307/100528845-7aa57b00-31e1-11eb-966f-c1fb7aeb031b.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #12697: Refactor airflow plugins command
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #12697:
URL: https://github.com/apache/airflow/pull/12697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12697: Refactor airflow plugins command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12697:
URL: https://github.com/apache/airflow/pull/12697#issuecomment-735347258
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12697: Refactor airflow plugins command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12697:
URL: https://github.com/apache/airflow/pull/12697#discussion_r532176642
##########
File path: airflow/cli/simple_table.py
##########
@@ -28,6 +28,7 @@ def __init__(self, *args, **kwargs):
self.pad_edge = kwargs.get("pad_edge", False)
self.box = kwargs.get("box", ASCII_DOUBLE_HEAD)
self.show_header = kwargs.get("show_header", False)
+ self.header_style = kwargs.get("header_style", "bold green")
Review comment:
Otherwise all look good to me. Much much nicer & more comprehensible output now 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12697: Refactor airflow plugins command
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12697:
URL: https://github.com/apache/airflow/pull/12697#discussion_r532184243
##########
File path: airflow/cli/simple_table.py
##########
@@ -28,6 +28,7 @@ def __init__(self, *args, **kwargs):
self.pad_edge = kwargs.get("pad_edge", False)
self.box = kwargs.get("box", ASCII_DOUBLE_HEAD)
self.show_header = kwargs.get("show_header", False)
+ self.header_style = kwargs.get("header_style", "bold green")
Review comment:
Good catch, that should not be part of this change 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12697: Refactor airflow plugins command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12697:
URL: https://github.com/apache/airflow/pull/12697#discussion_r532175993
##########
File path: airflow/cli/simple_table.py
##########
@@ -28,6 +28,7 @@ def __init__(self, *args, **kwargs):
self.pad_edge = kwargs.get("pad_edge", False)
self.box = kwargs.get("box", ASCII_DOUBLE_HEAD)
self.show_header = kwargs.get("show_header", False)
+ self.header_style = kwargs.get("header_style", "bold green")
Review comment:
I cannot relate this change to other changes in this PR, because there is no header explicitly specified for the `SimpleTable`s created in this module.
May you please help clarify a bit? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org