You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nabarunnag <gi...@git.apache.org> on 2017/08/29 20:07:52 UTC
[GitHub] geode pull request #749: GEODE-3502: Added awaitility clauses.
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/749
GEODE-3502: Added awaitility clauses.
* Added awaitility clauses while waiting for the stat comparison checks
* Replaced the deprecated Wait Criterion with Awaitility clause with increased timeout
* Replaced the invokeAsync with invoke to make the test identical to the one in ClientHealthStatsDUnitTest
* Removed the commented out flaky tag
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3502
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #749
----
commit 1c24be8dfb1e57d6fa8db9687110ffff3890fdde
Author: nabarun <nn...@pivotal.io>
Date: 2017-08-29T18:05:28Z
GEODE-3502: Added awaitility clauses.
* Added awaitility clauses while waiting for the stat comparison checks
* Replaced the deprecated Wait Criterion with Awaitility clause with increased timeout
* Replaced the invokeAsync with invoke to make the test identical to the one in ClientHealthStatsDUnitTest
* Removed the commented out flaky tag
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #749: GEODE-3502: Added awaitility clauses.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #749: GEODE-3502: Added awaitility clauses.
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/749
@ladyVader @jhuynh1 @upthewaterspout @boglesby
-- Potential reviewers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---