svn commit: r1448641 - /sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java

[fm...@apache.org]

Author: fmeschbe
Date: Thu Feb 21 13:57:30 2013
New Revision: 1448641

URL: http://svn.apache.org/r1448641
Log:
SLING-2738 Log an error message if parsing the multipart/form-data request fails

Modified:
    sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java

Modified: sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java?rev=1448641&r1=1448640&r2=1448641&view=diff
==============================================================================
--- sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java (original)
+++ sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java Thu Feb 21 13:57:30 2013
@@ -36,6 +36,7 @@ import org.apache.commons.fileupload.ser
 import org.apache.commons.fileupload.servlet.ServletRequestContext;
 import org.apache.sling.api.request.RequestParameter;
 import org.apache.sling.api.request.RequestParameterMap;
+import org.slf4j.LoggerFactory;
 
 public class ParameterSupport {
 
@@ -197,15 +198,19 @@ public class ParameterSupport {
         };
 
         // Parse the request
+        List<?> /* FileItem */items = null;
         try {
-            List<?> /* FileItem */items = upload.parseRequest(rc);
+            items = upload.parseRequest(rc);
+        } catch (FileUploadException fue) {
+            LoggerFactory.getLogger(getClass()).error("parseMultiPartPost: Error parsing request", fue);
+        }
+
+        if (items != null && items.size() > 0) {
             for (Iterator<?> ii = items.iterator(); ii.hasNext();) {
                 FileItem fileItem = (FileItem) ii.next();
                 RequestParameter pp = new MultipartRequestParameter(fileItem);
                 parameters.addParameter(fileItem.getFieldName(), pp);
             }
-        } catch (FileUploadException fue) {
-            // TODO: log
         }
     }