[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1536: IGNITE-18207 Sql. Pushdown DISTINCT aggregate with no particular function

[GitBox <gi...@apache.org>]

korlov42 commented on code in PR #1536:
URL: https://github.com/apache/ignite-3/pull/1536#discussion_r1082494820


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/AbstractBasicIntegrationTest.java:
##########
@@ -244,9 +241,22 @@ protected QueryProcessor getEngine() {
      * @param rules Additional rules need to be disabled.
      */
     static QueryChecker assertQuery(String qry, JoinType joinType, String... rules) {
-        return AbstractBasicIntegrationTest.assertQuery(qry.replaceAll("(?i)^select", "select "
-                + Stream.concat(Arrays.stream(joinType.disabledRules), Arrays.stream(rules))
-                .collect(Collectors.joining("','", "/*+ DISABLE_RULE('", "') */"))));
+        return assertQuery(qry)
+                .disableRules(joinType.disabledRules)
+                .disableRules(rules);
+    }
+
+    /**
+     * Used for join checks, disables other join rules for executing exact join algo.

Review Comment:
   I believe it's used for aggregation check, not join



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org