[jira] [Commented] (TINKERPOP3-695) test not calling convertId()

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567215#comment-14567215 ] 

stephen mallette commented on TINKERPOP3-695:
---------------------------------------------

just pushed this:

https://github.com/apache/incubator-tinkerpop/commit/bfe1e983ffc7eb9487f7172ba8b2ea77ae86d477

I would think that this should allow those tests to pass properly now.  You don't {{supportNumericIds}} (and other similar identifiers) so the tests still execute but because we now check {{willAllowId}} before asserting failure (which should return {{true}} in your case, the tests should pass.  

> test not calling convertId()
> ----------------------------
>
>                 Key: TINKERPOP3-695
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-695
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: test-suite
>            Reporter: Ran Magen
>            Assignee: stephen mallette
>             Fix For: 3.0.0.GA
>
>
> any test that uses Attachable to load its graph (e.g. using the Gryo loader) will not pass the id through the graph providers convertId(id). there are around 60 different tests affected.
> The offending line:
> https://github.com/apache/incubator-tinkerpop/blob/4bbbb6365f36c20ad63ca4665657fd1169a7d246/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L276



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)