You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@cloudera.com> on 2015/12/10 03:25:26 UTC
Review Request 41179: SQOOP-2725
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41179/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2725
https://issues.apache.org/jira/browse/SQOOP-2725
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases
Diffs
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 0da7ea8
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java f30d587
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java fa26c14
test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef
test/src/main/java/org/apache/sqoop/test/data/DataSet.java 5e109b1
test/src/main/java/org/apache/sqoop/test/data/ShortStories.java 66bf2cd
test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 5b75389
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java c1f355f
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java c843448
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java 8c65898
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java c39c8d6
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java e6f6e0d
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java 411b07e
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java 1790f96
test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java e964422
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java 5053b56
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 25cdb68
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 686572a
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java 131ad5e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 42bff65
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 68dc65e
test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java 4ecb018
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java 7b2aced
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java c2709a7
Diff: https://reviews.apache.org/r/41179/diff/
Testing
-------
yes
Thanks,
Abraham Fine
Re: Review Request 41179: SQOOP-2725
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41179/#review110450
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Dec. 14, 2015, 11:50 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41179/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 11:50 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2725
> https://issues.apache.org/jira/browse/SQOOP-2725
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases
>
>
> Diffs
> -----
>
> common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 0da7ea8
> common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java f30d587
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java fa26c14
> test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef
> test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 12bcad1
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java c1f355f
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java c843448
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java 8c65898
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java c39c8d6
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java e6f6e0d
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java 411b07e
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java 1790f96
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java 5053b56
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 25cdb68
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 686572a
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java f850768
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 42bff65
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 68dc65e
> test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java 4ecb018
>
> Diff: https://reviews.apache.org/r/41179/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 41179: SQOOP-2725
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41179/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 11:50 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2725
https://issues.apache.org/jira/browse/SQOOP-2725
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 0da7ea8
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java f30d587
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java fa26c14
test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef
test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 12bcad1
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java c1f355f
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java c843448
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java 8c65898
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java c39c8d6
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java e6f6e0d
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java 411b07e
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java 1790f96
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java 5053b56
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 25cdb68
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 686572a
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java f850768
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 42bff65
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 68dc65e
test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java 4ecb018
Diff: https://reviews.apache.org/r/41179/diff/
Testing
-------
yes
Thanks,
Abraham Fine
Re: Review Request 41179: SQOOP-2725
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41179/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 6:49 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2725
https://issues.apache.org/jira/browse/SQOOP-2725
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases
Diffs (updated)
-----
common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 0da7ea8
common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java f30d587
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java fa26c14
test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef
test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 12bcad1
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java c1f355f
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java c843448
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java 8c65898
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java c39c8d6
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java e6f6e0d
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java 411b07e
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java 1790f96
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java 5053b56
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 25cdb68
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 686572a
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java f850768
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 42bff65
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 68dc65e
test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java 4ecb018
Diff: https://reviews.apache.org/r/41179/diff/
Testing
-------
yes
Thanks,
Abraham Fine