You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/04 08:44:06 UTC
Review Request 35052: DRILL-2089: Part 7--Post-move hygiene
(simplification, renaming, whitespace).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement,
DrillPreparedStatement, DrillStatementImpl, DrillHandler]
Renamed DrillConnection.config() to more conventional getConfig().
[DrillConnection, DrillConnectionImpl]
Removed now-unneeded "abstract" and eliminated now-unneeded subclasses.
[DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory]
Simplified boolean Driver.load() to void. [Driver]
- Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest]
Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl]
Adjusted unknown-case handling, logging. [DrillColumnMetaDataList]
Wrapped lines; adjusted other whitespace.
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3
Diff: https://reviews.apache.org/r/35052/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35052: DRILL-2089: Part 7--Post-move hygiene
(simplification, renaming, whitespace).
Posted by Daniel Barclay <db...@maprtech.com>.
> On June 10, 2015, 5:21 a.m., Parth Chandra wrote:
> > One more empty file in this change set. Can you check?
Fixed(?).
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/#review87354
-----------------------------------------------------------
On June 10, 2015, 7:05 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35052/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 7:05 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement,
> DrillPreparedStatement, DrillStatementImpl, DrillHandler]
>
> Renamed DrillConnection.config() to more conventional getConfig().
> [DrillConnection, DrillConnectionImpl]
>
> Removed now-unneeded "abstract" and eliminated now-unneeded subclasses.
> [DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory]
>
> Simplified boolean Driver.load() to void. [Driver]
> - Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest]
>
> Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl]
>
> Adjusted unknown-case handling, logging. [DrillColumnMetaDataList]
>
> Wrapped lines; adjusted other whitespace.
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3
>
> Diff: https://reviews.apache.org/r/35052/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35052: DRILL-2089: Part 7--Post-move hygiene
(simplification, renaming, whitespace).
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/#review87354
-----------------------------------------------------------
Ship it!
One more empty file in this change set. Can you check?
- Parth Chandra
On June 4, 2015, 6:44 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35052/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 6:44 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement,
> DrillPreparedStatement, DrillStatementImpl, DrillHandler]
>
> Renamed DrillConnection.config() to more conventional getConfig().
> [DrillConnection, DrillConnectionImpl]
>
> Removed now-unneeded "abstract" and eliminated now-unneeded subclasses.
> [DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory]
>
> Simplified boolean Driver.load() to void. [Driver]
> - Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest]
>
> Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl]
>
> Adjusted unknown-case handling, logging. [DrillColumnMetaDataList]
>
> Wrapped lines; adjusted other whitespace.
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3
>
> Diff: https://reviews.apache.org/r/35052/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35052: DRILL-2089: Part 7--Post-move hygiene
(simplification, renaming, whitespace).
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/
-----------------------------------------------------------
(Updated June 16, 2015, 1:47 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Re-uploading patches, trying to fix/work around Review Board empty-files problem.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement,
DrillPreparedStatement, DrillStatementImpl, DrillHandler]
Renamed DrillConnection.config() to more conventional getConfig().
[DrillConnection, DrillConnectionImpl]
Removed now-unneeded "abstract" and eliminated now-unneeded subclasses.
[DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory]
Simplified boolean Driver.load() to void. [Driver]
- Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest]
Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl]
Adjusted unknown-case handling, logging. [DrillColumnMetaDataList]
Wrapped lines; adjusted other whitespace.
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3
Diff: https://reviews.apache.org/r/35052/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35052: DRILL-2089: Part 7--Post-move hygiene
(simplification, renaming, whitespace).
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/
-----------------------------------------------------------
(Updated June 10, 2015, 7:05 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Re-built and uploaded base patch to fix empty file problem.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Fixed "cleanup()" to "cleanUp()". [DrillRemoteStatement,
DrillPreparedStatement, DrillStatementImpl, DrillHandler]
Renamed DrillConnection.config() to more conventional getConfig().
[DrillConnection, DrillConnectionImpl]
Removed now-unneeded "abstract" and eliminated now-unneeded subclasses.
[DrillConnectionImpl, DrillStatementImpl, DrillJdbc41Factory]
Simplified boolean Driver.load() to void. [Driver]
- Switched from "new Driver()" to "Driver.load()" in one case. [ConnectionTest]
Fixed "Optiq" -> "Drill", cleaned up createDriverVersion. [DriverImpl]
Adjusted unknown-case handling, logging. [DrillColumnMetaDataList]
Wrapped lines; adjusted other whitespace.
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java d64f980
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java 8a469c3
Diff: https://reviews.apache.org/r/35052/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay