You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/06/05 00:54:04 UTC
Review Request 35090: Update libprocess process to use synchronized.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35090/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs: MESOS-2805
https://issues.apache.org/jira/browse/MESOS-2805
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/process.hpp 79d1719932a3fdc90b6247d3a77adee123e72435
3rdparty/libprocess/src/process.cpp f1d3e5b6ed4a7fb541cc893e39c1d8186c493c9b
Diff: https://reviews.apache.org/r/35090/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 35090: Update libprocess process to use
synchronized.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35090/#review87814
-----------------------------------------------------------
Ship it!
At this point we might as well s/m/mutex/ to be more clear since folks won't use 'lock()' and 'unlock()'. I'll take care of that for you and commit!
- Benjamin Hindman
On June 5, 2015, 7:42 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35090/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 7:42 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Bugs: MESOS-2805
> https://issues.apache.org/jira/browse/MESOS-2805
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp 79d1719932a3fdc90b6247d3a77adee123e72435
> 3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58
>
> Diff: https://reviews.apache.org/r/35090/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 35090: Update libprocess process to use
synchronized.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35090/
-----------------------------------------------------------
(Updated June 5, 2015, 7:42 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Changes
-------
remove extra friendship.
Bugs: MESOS-2805
https://issues.apache.org/jira/browse/MESOS-2805
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/process.hpp 79d1719932a3fdc90b6247d3a77adee123e72435
3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58
Diff: https://reviews.apache.org/r/35090/diff/
Testing
-------
Thanks,
Joris Van Remoortere