[jira] Updated: (SHINDIG-1141) Make BasicRemoteContentFetcher configurable

["Arne Roomann-Kurrik (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Roomann-Kurrik updated SHINDIG-1141:
-----------------------------------------

    Attachment: issue100052_1.diff

> Make BasicRemoteContentFetcher configurable 
> --------------------------------------------
>
>                 Key: SHINDIG-1141
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1141
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Arne Roomann-Kurrik
>            Priority: Minor
>         Attachments: issue100052_1.diff
>
>
> BasicRemoteContentFetcher (BRCF) is a concrete implementation of the abstract RemoteContentFetcher class.  In certain cases it would be useful to swap out BRCF (for example, to use something other than curl or for unit testing) but it is explicitly created in several areas of the codebase.  
> The patch I am submitting (available for review at http://codereview.appspot.com/100052/show) makes BasicRemoteContentFetcher configurable in container.php.  It:
>   * Adds a new configuration parameter "remote_content_fetcher" which defaults to BRCF
>   * Removes hardcoded references to BRCF in favor of initializing the class specified in the configuration
>   * Cleans up some lines from src/gadgets/oauth/OAuthFetcher.php - I believe these had strange line endings (no text is changed)
>   * Removes unneeded imports from src/gadgets/servlet/GadgetRenderingServlet.php and src/gadgets/servlet/MetadataServlet.php

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.