[GitHub] [nifi] exceptionfactory commented on pull request #5918: NIFI-9850 Add support for multiple expressions to GrokReader

[GitBox <gi...@apache.org>]

exceptionfactory commented on pull request #5918:
URL: https://github.com/apache/nifi/pull/5918#issuecomment-1084765013


   Thanks for the feedback @ottobackwards!
   
   In response to your questions:
   
   1. Yes, the implicit schema handling remains the same. The `createRecordSchema` method evaluates fields from all configured Grok Expressions
   2. Implementing a Controller Service for sharing Grok Expression resources could be useful, particularly when paired with custom Grok Patterns. There is an open issue to make the custom patterns more configurable as well. This particular set of changes is more of an incremental improvement, so a well-designed Controller Service seems like a potential follow on approach
   3. The challenge of tracking the matching pattern is that different records could match different patterns. Perhaps this could be achieve through an additional record field, but it may not be necessary in all cases. Perhaps this could also be an additional feature?
   
   In the process of evaluating this change, there are some opportunities for additional improvements, although it seems better to focus those in separate tasks. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org