[GitHub] [pulsar] RobertIndie commented on a change in pull request #13777: Allow to configure metadata store URL in proxy.conf

[GitBox <gi...@apache.org>]

RobertIndie commented on a change in pull request #13777:
URL: https://github.com/apache/pulsar/pull/13777#discussion_r792305518



##########
File path: site2/docs/administration-proxy.md
##########
@@ -55,7 +55,9 @@ To start the proxy:
 
 ```bash
 $ cd /path/to/pulsar/directory
-$ bin/pulsar proxy
+$ bin/pulsar proxy \

Review comment:
       Is it necessary to update here?

##########
File path: site2/website-next/docs/concepts-architecture-overview.md
##########
@@ -127,10 +127,10 @@ The **Pulsar proxy** provides a solution to this problem by acting as a single g
 Architecturally, the Pulsar proxy gets all the information it requires from ZooKeeper. When starting the proxy on a machine, you only need to provide ZooKeeper connection strings for the cluster-specific and instance-wide configuration store clusters. Here's an example:
 
 ```bash
-
+$ cd /path/to/pulsar/directory
 $ bin/pulsar proxy \
-  --zookeeper-servers zk-0,zk-1,zk-2 \
-  --configuration-store-servers zk-0,zk-1,zk-2
+  --metadata-store zk-0,zk-1,zk-2 \
+  -configuration-store-servers zk-0,zk-1,zk-2

Review comment:
       ```suggestion
     --configuration-store-servers zk-0,zk-1,zk-2
   ```

##########
File path: site2/website-next/docs/administration-proxy.md
##########
@@ -62,9 +62,10 @@ Note that if you do not use functions, you do not need to configure `functionWor
 To start the proxy:
 
 ```bash
-
 $ cd /path/to/pulsar/directory
-$ bin/pulsar proxy
+$ bin/pulsar proxy \
+  --metadata-store zk-0,zk-1,zk-2 \
+  -configuration-store-servers zk-0,zk-1,zk-2

Review comment:
       ```suggestion
     --configuration-store-servers zk-0,zk-1,zk-2
   ```

##########
File path: site2/docs/administration-proxy.md
##########
@@ -55,7 +55,9 @@ To start the proxy:
 
 ```bash
 $ cd /path/to/pulsar/directory
-$ bin/pulsar proxy
+$ bin/pulsar proxy \
+  --metadata-store zk-0,zk-1,zk-2 \
+  -configuration-store-servers zk-0,zk-1,zk-2

Review comment:
       ```suggestion
     --configuration-store-servers zk-0,zk-1,zk-2
   ```

##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -72,13 +72,15 @@
 
     @Parameter(names = { "-zk", "--zookeeper-servers" }, description = "Local zookeeper connection string")
     private String zookeeperServers = "";
+    @Parameter(names = { "-md", "--metadata-store" }, description = "Metadata Store service url. eg: zk:my-zk:2181")
+    private String metadataStoreUrl = "";
 
     @Deprecated
     @Parameter(names = { "-gzk", "--global-zookeeper-servers" }, description = "Global zookeeper connection string")
     private String globalZookeeperServers = "";
 
     @Parameter(names = { "-cs", "--configuration-store-servers" },
-        description = "Configuration store connection string")
+                    description = "Configuration store connection string")
     private String configurationStoreServers = "";

Review comment:
       Do we need to add `configurationMetadataStore` and deprecate this field to make it consistent with the config?

##########
File path: site2/docs/concepts-architecture-overview.md
##########
@@ -125,9 +125,10 @@ The **Pulsar proxy** provides a solution to this problem by acting as a single g
 Architecturally, the Pulsar proxy gets all the information it requires from ZooKeeper. When starting the proxy on a machine, you only need to provide ZooKeeper connection strings for the cluster-specific and instance-wide configuration store clusters. Here's an example:
 
 ```bash
+$ cd /path/to/pulsar/directory
 $ bin/pulsar proxy \
-  --zookeeper-servers zk-0,zk-1,zk-2 \
-  --configuration-store-servers zk-0,zk-1,zk-2
+  --metadata-store zk-0,zk-1,zk-2 \
+  -configuration-store-servers zk-0,zk-1,zk-2

Review comment:
       ```suggestion
     --configuration-store-servers zk-0,zk-1,zk-2
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org