You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/23 04:48:41 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #22351: Merge DialectSchemaMetaDataLoader#loadSchemaNames to SchemaMetaDataLoader#loadSchemaNames method
strongduanmu opened a new pull request, #22351:
URL: https://github.com/apache/shardingsphere/pull/22351
Changes proposed in this pull request:
- merge DialectSchemaMetaDataLoader#loadSchemaNames to SchemaMetaDataLoader#loadSchemaNames method
- adjust private method sequence in OpenGaussSchemaMetaDataLoader and PostgreSQLSchemaMetaDataLoader
- add unit test for SchemaMetaDataLoader#loadSchemaNames
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22351: Merge DialectSchemaMetaDataLoader#loadSchemaNames to SchemaMetaDataLoader#loadSchemaNames method
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22351:
URL: https://github.com/apache/shardingsphere/pull/22351#issuecomment-1324568834
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22351](https://codecov.io/gh/apache/shardingsphere/pull/22351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6bd8aa) into [master](https://codecov.io/gh/apache/shardingsphere/commit/77c234b198ae3bae382f6ecf4d99b734567e754d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77c234b) will **increase** coverage by `0.01%`.
> The diff coverage is `62.09%`.
```diff
@@ Coverage Diff @@
## master #22351 +/- ##
============================================
+ Coverage 51.02% 51.04% +0.01%
+ Complexity 2508 2506 -2
============================================
Files 4164 4163 -1
Lines 57838 57817 -21
Branches 9822 9814 -8
============================================
Hits 29510 29510
+ Misses 25786 25774 -12
+ Partials 2542 2533 -9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../loader/dialect/OpenGaussSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvT3BlbkdhdXNzU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `2.94% <0.00%> (+0.16%)` | :arrow_up: |
| [...ase/schema/loader/common/SchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2NvbW1vbi9TY2hlbWFNZXRhRGF0YUxvYWRlci5qYXZh) | `86.66% <92.85%> (ø)` | |
| [...loader/dialect/PostgreSQLSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvUG9zdGdyZVNRTFNjaGVtYU1ldGFEYXRhTG9hZGVyLmphdmE=) | `90.52% <95.45%> (+3.14%)` | :arrow_up: |
| [...ingletable/datanode/SingleTableDataNodeLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NpbmdsZS10YWJsZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaW5nbGV0YWJsZS9kYXRhbm9kZS9TaW5nbGVUYWJsZURhdGFOb2RlTG9hZGVyLmphdmE=) | `92.85% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia merged pull request #22351: Merge DialectSchemaMetaDataLoader#loadSchemaNames to SchemaMetaDataLoader#loadSchemaNames method
Posted by GitBox <gi...@apache.org>.
taojintianxia merged PR #22351:
URL: https://github.com/apache/shardingsphere/pull/22351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org