You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tgravescs <gi...@git.apache.org> on 2017/11/29 18:04:36 UTC
[GitHub] spark pull request #19850: [SPARK-22653] executorAddress registered in Coars...
GitHub user tgravescs opened a pull request:
https://github.com/apache/spark/pull/19850
[SPARK-22653] executorAddress registered in CoarseGrainedSchedulerBac…
https://issues.apache.org/jira/browse/SPARK-22653
executorRef.address can be null, pass the executorAddress which accounts for it being null a few lines above the fix.
Manually tested this patch. You can reproduce the issue by running a simple spark-shell in yarn client mode with dynamic allocation and request some executors up front. Let those executors idle timeout. Get a heap dump. Without this fix, you will see that addressToExecutorId still contains the ids, with the fix addressToExecutorId is properly cleaned up.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgravescs/spark SPARK-22653
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19850
----
commit 2703214015c71ab4b2f7a0fba258b1107411e449
Author: Thomas Graves <tg...@oath.com>
Date: 2017-11-29T16:43:10Z
[SPARK-22653] executorAddress registered in CoarseGrainedSchedulerBackend.executorDataMap is null
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653] executorAddress registered in CoarseGraine...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19850
good catch! merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653] executorAddress registered in CoarseGraine...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19850
**[Test build #84310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84310/testReport)** for PR 19850 at commit [`2703214`](https://github.com/apache/spark/commit/2703214015c71ab4b2f7a0fba258b1107411e449).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653] executorAddress registered in CoarseGraine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84310/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653] executorAddress registered in CoarseGraine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19850
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653] executorAddress registered in CoarseGraine...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19850
Please update the PR title:
```
[SPARK-22653][CORE] executorAddress registered in CoarseGrainedSchedulerBackend.executorDataMap should not be null
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653] executorAddress registered in CoarseGraine...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19850
**[Test build #84310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84310/testReport)** for PR 19850 at commit [`2703214`](https://github.com/apache/spark/commit/2703214015c71ab4b2f7a0fba258b1107411e449).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19850: [SPARK-22653][CORE] executorAddress registered in Coarse...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/19850
thanks @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19850: [SPARK-22653] executorAddress registered in Coars...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19850
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org