You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/01 15:11:58 UTC
[GitHub] [solr] mkhludnev opened a new pull request, #1260: Solr 778 transfer mlt right
mkhludnev opened a new pull request, #1260:
URL: https://github.com/apache/solr/pull/1260
I think this is a somewhat reliable solution for the problem with distributed mlt component. Reminder, now it naively relies on parsing `booleanQuery.toString()` that's unacceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] alessandrobenedetti commented on pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "alessandrobenedetti (via GitHub)" <gi...@apache.org>.
alessandrobenedetti commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1439846587
Back in the days, in 2017 when I was not a committer yet, I did a massive refactor of the Lucene More Like This code (https://www.slideshare.net/SeaseLtd/how-the-lucene-more-like-this-works, https://issues.apache.org/jira/browse/LUCENE-8326) and also presented it at various conf.
But I didn't get much traction and the work basically got wasted (a lot of tests and code cleaned up)
Long time has passed so it's very likely I would do it differently nowadays but I don't have the time (or fundings?) to do it again right now.
So in general I am in total favor of refactoring the Lucene side of things, happy to review it, I can't guarantee when, but I'll do my best!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] alessandrobenedetti commented on pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "alessandrobenedetti (via GitHub)" <gi...@apache.org>.
alessandrobenedetti commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1438816549
You are welcome! I saw you changed the anonymous 'id' to 'docNum'.
It's probably fine, but it didn't look intuitive to me as a name so I checked in the Solr code base, and it seems 'docId' to be more present and widespread used?
You know it's a super minor thing, I have a soft preference for using 'docId' but up to you!
And thanks for the nice work and refactoring, the MoreLikeThis needed some love, I really appreciate it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1110573135
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {
}
}
+ private static NamedList<String> putMLTIntoParamList(
Review Comment:
We strive to match the Google Java Style guide, and that means using "Mlt" and not "MLT" inside names. But maybe MLT is so pervasive capitalized this way in the code already (before striving for this) that you are trying to be consistent? Any way; do as you wish.
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java:
##########
@@ -389,5 +389,29 @@ public void test() throws Exception {
Long actual = ((SolrDocumentList) entry.getValue()).getNumFound();
assertEquals("MLT mismatch for id=" + key, expected, actual);
}
+ // test bost mlt.qf
Review Comment:
```suggestion
// test boost mlt.qf
```
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {
}
}
+ private static NamedList<String> putMLTIntoParamList(
+ IndexSchema schema,
+ List<MoreLikeThisHandler.InterestingTerm> terms,
+ String uniqueField,
+ String uniqueVal) {
+ final NamedList<String> mltQ = new NamedList<>();
+ StringBuilder q = new StringBuilder("{!bool");
+ q.append(" must_not=$");
+ int cnt = 0;
+ String param = "mltq" + (cnt++);
+ q.append(param);
+ mltQ.add(param, "{!field f=" + uniqueField + "}" + uniqueVal);
+ final StringBuilder reuseStr = new StringBuilder();
+ final CharsRefBuilder reuseChar = new CharsRefBuilder();
+ for (MoreLikeThisHandler.InterestingTerm term : terms) {
+ param = "mltq" + (cnt++);
+ q.append(" should=$");
+ q.append(param);
+ mltQ.add(param, toParserParam(schema, term.term, term.boost, reuseStr, reuseChar));
+ }
+ q.append("}");
+ mltQ.add(CommonParams.Q, q.toString());
+ return mltQ;
+ }
+
+ private static String toParserParam(
+ IndexSchema schema,
+ Term term1,
+ float boost,
+ StringBuilder reuseStr,
+ CharsRefBuilder reuseChar) {
+ reuseStr.setLength(0);
+ if (boost != 1f) {
+ reuseStr.append("{!boost b=");
+ reuseStr.append(boost);
+ reuseStr.append("}");
+ }
+ final String field = term1.field();
+ final CharsRef val =
Review Comment:
See `org.apache.solr.client.solrj.util.ClientUtils#encodeLocalParamVal`
##########
solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java:
##########
@@ -422,6 +417,24 @@ public DocListAndSet getMoreLikeThis(
return results;
}
+ public List<InterestingTerm> getInterestingTerms(int docid) throws IOException {
+ final ArrayList<InterestingTerm> interestingTerms = new ArrayList<>();
+ getBoostedMLTQuery(docid, interestingTerms);
+ return interestingTerms;
+ }
+ /**
+ * Sets {@link #boostedMLTQuery} and return, also put interesting terms into terms list if
+ * provided non-null. Sorry. It lacks of perfection and overall sense.
Review Comment:
LOL.... so it can help make it less ugly to name the parameter outputTerms or something like that. I've also seen a strategy where the return value is a Pair or something like that. There is such a class in SolrJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1111240673
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {
}
}
+ private static NamedList<String> putMLTIntoParamList(
+ IndexSchema schema,
+ List<MoreLikeThisHandler.InterestingTerm> terms,
+ String uniqueField,
+ String uniqueVal) {
+ final NamedList<String> mltQ = new NamedList<>();
+ StringBuilder q = new StringBuilder("{!bool");
+ q.append(" must_not=$");
+ int cnt = 0;
+ String param = "mltq" + (cnt++);
+ q.append(param);
+ mltQ.add(param, "{!field f=" + uniqueField + "}" + uniqueVal);
+ final StringBuilder reuseStr = new StringBuilder();
+ final CharsRefBuilder reuseChar = new CharsRefBuilder();
+ for (MoreLikeThisHandler.InterestingTerm term : terms) {
+ param = "mltq" + (cnt++);
+ q.append(" should=$");
+ q.append(param);
+ mltQ.add(param, toParserParam(schema, term.term, term.boost, reuseStr, reuseChar));
+ }
+ q.append("}");
+ mltQ.add(CommonParams.Q, q.toString());
+ return mltQ;
+ }
+
+ private static String toParserParam(
+ IndexSchema schema,
+ Term term1,
+ float boost,
+ StringBuilder reuseStr,
+ CharsRefBuilder reuseChar) {
+ reuseStr.setLength(0);
+ if (boost != 1f) {
+ reuseStr.append("{!boost b=");
+ reuseStr.append(boost);
+ reuseStr.append("}");
+ }
+ final String field = term1.field();
+ final CharsRef val =
Review Comment:
Thanks for suggestion, but I don't think it often matters much for field name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1113304963
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java:
##########
@@ -389,5 +389,29 @@ public void test() throws Exception {
Long actual = ((SolrDocumentList) entry.getValue()).getNumFound();
assertEquals("MLT mismatch for id=" + key, expected, actual);
}
+ // test boost mlt.qf
+ query(
+ "q",
+ "lowerfilt:moon",
+ "fl",
+ id,
+ MoreLikeThisParams.MIN_TERM_FREQ,
+ 2,
+ MoreLikeThisParams.MIN_DOC_FREQ,
+ 1,
+ "sort",
+ "id_i1 desc",
+ "mlt",
+ "true",
+ "mlt.fl",
+ "lowerfilt1,lowerfilt",
+ "mlt.qf",
+ "lowerfilt1^1.2 lowerfilt^3.4",
+ "qt",
+ requestHandlerName,
+ "shards.qt",
+ requestHandlerName,
+ "mlt.count",
+ "20");
Review Comment:
It boils down to org.apache.solr.BaseDistributedSearchTestCase#query(boolean, org.apache.solr.common.params.SolrParams) which compares distributed and standalone responses. // ..so, if both of them returns nothing, it's perfectly fine ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "alessandrobenedetti (via GitHub)" <gi...@apache.org>.
alessandrobenedetti commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1112953125
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -95,23 +98,23 @@ public void process(ResponseBuilder rb) throws IOException {
rb.rsp.add("moreLikeThis", new NamedList<DocList>());
return;
}
-
MoreLikeThisHandler.MoreLikeThisHelper mlt =
new MoreLikeThisHandler.MoreLikeThisHelper(params, searcher);
-
- NamedList<BooleanQuery> bQuery = mlt.getMoreLikeTheseQuery(rb.getResults().docList);
-
- NamedList<String> temp = new NamedList<>();
- Iterator<Entry<String, BooleanQuery>> idToQueryIt = bQuery.iterator();
-
- while (idToQueryIt.hasNext()) {
- Entry<String, BooleanQuery> idToQuery = idToQueryIt.next();
- String s = idToQuery.getValue().toString();
-
- log.debug("MLT Query:{}", s);
- temp.add(idToQuery.getKey(), idToQuery.getValue().toString());
+ NamedList<NamedList<?>> temp = new NamedList<>();
Review Comment:
we can leverage this contribution for some minor refactoring?
rename 'temp' to 'docIdsAndMltQueries' , or something like that?
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -95,23 +98,23 @@ public void process(ResponseBuilder rb) throws IOException {
rb.rsp.add("moreLikeThis", new NamedList<DocList>());
return;
}
-
MoreLikeThisHandler.MoreLikeThisHelper mlt =
new MoreLikeThisHandler.MoreLikeThisHelper(params, searcher);
-
- NamedList<BooleanQuery> bQuery = mlt.getMoreLikeTheseQuery(rb.getResults().docList);
-
- NamedList<String> temp = new NamedList<>();
- Iterator<Entry<String, BooleanQuery>> idToQueryIt = bQuery.iterator();
-
- while (idToQueryIt.hasNext()) {
- Entry<String, BooleanQuery> idToQuery = idToQueryIt.next();
- String s = idToQuery.getValue().toString();
-
- log.debug("MLT Query:{}", s);
- temp.add(idToQuery.getKey(), idToQuery.getValue().toString());
+ NamedList<NamedList<?>> temp = new NamedList<>();
+ for (DocIterator iterator = rb.getResults().docList.iterator(); iterator.hasNext(); ) {
Review Comment:
DocIterator searchResults ?
DocIterator results ?
never been a fan of names that are basically the type of the object
##########
solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java:
##########
@@ -466,37 +456,19 @@ public DocListAndSet getMoreLikeThis(
}
return results;
}
-
- public NamedList<BooleanQuery> getMoreLikeTheseQuery(DocList docs) throws IOException {
- IndexSchema schema = searcher.getSchema();
- NamedList<BooleanQuery> result = new NamedList<>();
- DocIterator iterator = docs.iterator();
- while (iterator.hasNext()) {
- int id = iterator.nextDoc();
- String uniqueId = schema.printableUniqueKey(reader.document(id));
-
- BooleanQuery mltquery = (BooleanQuery) mlt.like(id);
- if (mltquery.clauses().size() == 0) {
- return result;
- }
- mltquery = (BooleanQuery) getBoostedQuery(mltquery);
-
- // exclude current document from results
- BooleanQuery.Builder mltQuery = new BooleanQuery.Builder();
- mltQuery.add(mltquery, BooleanClause.Occur.MUST);
-
- mltQuery.add(
- new TermQuery(new Term(uniqueKeyField.getName(), uniqueId)),
- BooleanClause.Occur.MUST_NOT);
- result.add(uniqueId, mltQuery.build());
- }
-
- return result;
- }
-
- private void fillInterestingTermsFromMLTQuery(Query query, List<InterestingTerm> terms) {
- Collection<BooleanClause> clauses = ((BooleanQuery) query).clauses();
+ /**
+ * Yields terms with boosts from the boosted MLT query.
+ *
+ * @param maxTerms how many terms to return, negative value let to return all
Review Comment:
maybe:
@param maxTerms how many terms to return, a negative value means all terms are returned
?
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -95,23 +98,23 @@ public void process(ResponseBuilder rb) throws IOException {
rb.rsp.add("moreLikeThis", new NamedList<DocList>());
return;
}
-
MoreLikeThisHandler.MoreLikeThisHelper mlt =
new MoreLikeThisHandler.MoreLikeThisHelper(params, searcher);
-
- NamedList<BooleanQuery> bQuery = mlt.getMoreLikeTheseQuery(rb.getResults().docList);
-
- NamedList<String> temp = new NamedList<>();
- Iterator<Entry<String, BooleanQuery>> idToQueryIt = bQuery.iterator();
-
- while (idToQueryIt.hasNext()) {
- Entry<String, BooleanQuery> idToQuery = idToQueryIt.next();
- String s = idToQuery.getValue().toString();
-
- log.debug("MLT Query:{}", s);
- temp.add(idToQuery.getKey(), idToQuery.getValue().toString());
+ NamedList<NamedList<?>> temp = new NamedList<>();
+ for (DocIterator iterator = rb.getResults().docList.iterator(); iterator.hasNext(); ) {
+ int id = iterator.nextDoc();
Review Comment:
docId maybe?
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java:
##########
@@ -389,5 +389,29 @@ public void test() throws Exception {
Long actual = ((SolrDocumentList) entry.getValue()).getNumFound();
assertEquals("MLT mismatch for id=" + key, expected, actual);
}
+ // test boost mlt.qf
+ query(
+ "q",
+ "lowerfilt:moon",
+ "fl",
+ id,
+ MoreLikeThisParams.MIN_TERM_FREQ,
+ 2,
+ MoreLikeThisParams.MIN_DOC_FREQ,
+ 1,
+ "sort",
+ "id_i1 desc",
+ "mlt",
+ "true",
+ "mlt.fl",
+ "lowerfilt1,lowerfilt",
+ "mlt.qf",
+ "lowerfilt1^1.2 lowerfilt^3.4",
+ "qt",
+ requestHandlerName,
+ "shards.qt",
+ requestHandlerName,
+ "mlt.count",
+ "20");
Review Comment:
I was trying to understand why we have the 'query()' here, with no assertions. I can spend more time refreshing on those tests, but given you have been working recently on these, can you refresh my mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1111239181
##########
solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java:
##########
@@ -422,6 +417,24 @@ public DocListAndSet getMoreLikeThis(
return results;
}
+ public List<InterestingTerm> getInterestingTerms(int docid) throws IOException {
+ final ArrayList<InterestingTerm> interestingTerms = new ArrayList<>();
+ getBoostedMLTQuery(docid, interestingTerms);
+ return interestingTerms;
+ }
+ /**
+ * Sets {@link #boostedMLTQuery} and return, also put interesting terms into terms list if
+ * provided non-null. Sorry. It lacks of perfection and overall sense.
Review Comment:
Got it. This collection also let to bypass terms extraction. I'm not sure it allows to save a lot of computation, I prefer to keep it lazy. I tries to toss code a little to improve. The root cause of this ugliness is lack of proper public method in Lucene. It's worth to decouple terms extraction, field assignment and query factoring. It will let to boost clauses without boolean query ripping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1111241215
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {
}
}
+ private static NamedList<String> putMLTIntoParamList(
Review Comment:
We have a hundred of occurrences of `MLT`, it might be great idea, but out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on a diff in pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r1111871573
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException {
}
}
+ private static NamedList<String> putMLTIntoParamList(
Review Comment:
ok. I put it as `mltViaQueryParams`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1438787312
Thanks a lot @alessandrobenedetti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev merged pull request #1260: SOLR-16682: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev merged PR #1260:
URL: https://github.com/apache/solr/pull/1260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1438944190
I think more often about Lucene `docNums`. Ok turned to id. Do you think it's worth to bother with open some MLT methods in Lucene to allow to grab interesting terms without ripping boolean query? Or it's worth to think about generic query serialization framework?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on pull request #1260: SOLR-788: transfer mlt query for component right
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1446994594
I'll push it tomorrow. Please chime it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org