You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 18:30:33 UTC

[GitHub] [arrow] jcralmeida commented on a diff in pull request #12747: ARROW-16064: [Java] [C++] [FlightRPC] Add missing column metadata for type name on FlightSQL

jcralmeida commented on code in PR #12747:
URL: https://github.com/apache/arrow/pull/12747#discussion_r846382574


##########
format/FlightSql.proto:
##########
@@ -1491,6 +1493,7 @@ message TicketStatementQuery {
  *    - ARROW:FLIGHT:SQL:CATALOG_NAME      - Table's catalog name
  *    - ARROW:FLIGHT:SQL:DB_SCHEMA_NAME    - Database schema name
  *    - ARROW:FLIGHT:SQL:TABLE_NAME        - Table name
+ *    - ARROW:FLIGHT:SQL:TYPE_NAME         - Type name

Review Comment:
   I don't think we should use an enum because the values can vary by the sources



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org