[GitHub] [iceberg] rdblue commented on a diff in pull request #5592: AWS: Deprecate AwsClientFactories.s3Configuration()

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5592:
URL: https://github.com/apache/iceberg/pull/5592#discussion_r950907655


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -193,6 +193,14 @@ public static <T extends SdkClientBuilder> void configureEndpoint(T builder, Str
     }
   }
 
+  /**
+   * Build an S3Configuration object from two boolean flags, pathStyleAccess and
+   * s3UseArnRegionEnabled
+   *
+   * @deprecated Not for public use. To build an S3Configuration object, use
+   *     S3Configuration.builder() directly.

Review Comment:
   This should include a note like "will be removed in 2.0.0".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org