You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Shuler (JIRA)" <ji...@apache.org> on 2019/06/06 01:14:00 UTC
[jira] [Commented] (CASSANDRA-15050) JDK7 compatibility broken in
cassandra-2.2 by CASSANDRA-14821
[ https://issues.apache.org/jira/browse/CASSANDRA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857198#comment-16857198 ]
Michael Shuler commented on CASSANDRA-15050:
--------------------------------------------
{noformat}
(cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
(cassandra-2.2)mshuler@mana:~/git/cassandra$
(cassandra-2.2)mshuler@mana:~/git/cassandra$ git diff origin/cassandra-2.2
diff --git a/CHANGES.txt b/CHANGES.txt
index 1cc415312d..48bf14f5d4 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.2.15
+ * Fix JDK7 compatibility broken in cassandra-2.2 (CASSANDRA-15050)
* Support cross version messaging in in-jvm upgrade dtests (CASSANDRA-15078)
* Fix index summary redistribution cancellation (CASSANDRA-15045)
* Refactor Circle CI configuration (CASSANDRA-14806)
diff --git a/src/java/org/apache/cassandra/utils/MBeanWrapper.java b/src/java/org/apache/cassandra/utils/MBeanWrapper.java
index 3b5c7cb70c..1ee787d8d8 100644
--- a/src/java/org/apache/cassandra/utils/MBeanWrapper.java
+++ b/src/java/org/apache/cassandra/utils/MBeanWrapper.java
@@ -19,7 +19,6 @@
package org.apache.cassandra.utils;
import java.lang.management.ManagementFactory;
-import java.util.function.Consumer;
import javax.management.MBeanServer;
import javax.management.MalformedObjectNameException;
import javax.management.ObjectName;
@@ -206,4 +205,10 @@ public interface MBeanWrapper
this.handler = handler;
}
}
+
+ // Locally defined Consumer interface, to be compatible with Java 7. Only needed for cassandra-2.2
+ interface Consumer<T>
+ {
+ void accept(T e);
+ }
}
(cassandra-2.2)mshuler@mana:~/git/cassandra$
(cassandra-2.2)mshuler@mana:~/git/cassandra$ ant
Buildfile: /home/mshuler/git/cassandra/build.xml
init:
[mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
[mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
[mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
[mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
[mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
[mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
[mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
[mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
maven-ant-tasks-localrepo:
[copy] Copying 1 file to /home/mshuler/git/cassandra/build
maven-ant-tasks-download:
maven-ant-tasks-init:
maven-declare-dependencies:
maven-ant-tasks-retrieve-build:
[artifact:dependencies] Building ant file: /home/mshuler/git/cassandra/build/build-dependencies.xml
[artifact:dependencies] Building ant file: /home/mshuler/git/cassandra/build/build-dependencies-sources.xml
[copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
[copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
[copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
[unzip] Expanding: /home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar into /home/mshuler/git/cassandra/b
uild/lib/jars
check-gen-cql3-grammar:
gen-cql3-grammar:
[echo] Building Grammar /home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g ...
generate-cql-html:
build-project:
[echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
[javac] Compiling 45 source files to /home/mshuler/git/cassandra/build/classes/thrift
[javac] warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less tha
n -source '1.7'
[javac] Note: /home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java uses or overrides a depre
cated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 warning
[javac] Compiling 1171 source files to /home/mshuler/git/cassandra/build/classes/main
[javac] Note: Processing compiler hints annotations
[javac] warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less tha
n -source '1.7'
[javac] Note: Processing compiler hints annotations
[javac] Note: Writing compiler command file at META-INF/hotspot_compiler
[javac] Note: Done processing compiler hints annotations
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 warning
createVersionPropFile:
[mkdir] Created dir: /home/mshuler/git/cassandra/src/resources/org/apache/cassandra/config
[propertyfile] Creating new property file: /home/mshuler/git/cassandra/src/resources/org/apache/cassandra/config/version.properties
[copy] Copying 2 files to /home/mshuler/git/cassandra/build/classes/main
[copy] Copying 1 file to /home/mshuler/git/cassandra/conf
build:
build-test:
[javac] Compiling 384 source files to /home/mshuler/git/cassandra/build/test/classes
[javac] javac: invalid target release: 1.8
[javac] Usage: javac <options> <source files>
[javac] use -help for a list of possible options
BUILD FAILED
/home/mshuler/git/cassandra/build.xml:1204: Compile failed; see the compiler error output for details.
Total time: 49 seconds
{noformat}
> JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
> -------------------------------------------------------------
>
> Key: CASSANDRA-15050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15050
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Michael Shuler
> Assignee: Ted Petersson
> Priority: Normal
> Fix For: 2.2.x
>
> Attachments: 15050-2.2.txt
>
>
> CASSANDRA-14821 introduced some errors on JDK7. The build fails as follows:
> {noformat}
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
> java version "1.7.0_80"
> Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ ant jar
> Buildfile: /home/mshuler/git/cassandra/build.xml
> init:
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
> [mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
> maven-ant-tasks-localrepo:
> [copy] Copying 1 file to /home/mshuler/git/cassandra/build
> maven-ant-tasks-download:
> maven-ant-tasks-init:
> maven-declare-dependencies:
> maven-ant-tasks-retrieve-build:
> [artifact:dependencies] Building ant file: /home/mshuler/git/cassandra/build/build-dependencies.xml
> [artifact:dependencies] Building ant file: /home/mshuler/git/cassandra/build/build-dependencies-sources.xml
> [copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
> [copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
> [copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
> [unzip] Expanding: /home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar into /home/mshu
> ler/git/cassandra/build/lib/jars
> check-gen-cql3-grammar:
> gen-cql3-grammar:
> [echo] Building Grammar /home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g ...
> generate-cql-html:
> build-project:
> [echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
> [javac] Compiling 45 source files to /home/mshuler/git/cassandra/build/classes/thrift
> [javac] warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
> [javac] Note: /home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java uses o
> r overrides a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 1 warning
> [javac] Compiling 1171 source files to /home/mshuler/git/cassandra/build/classes/main
> [javac] Note: Processing compiler hints annotations
> [javac] warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:22: error: package java.uti
> l.function does not exist
> [javac] import java.util.function.Consumer;
> [javac] ^
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:203: error: cannot find sym
> bol
> [javac] private Consumer<Exception> handler;
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:204: error: cannot find sym
> bol
> [javac] OnException(Consumer<Exception> handler)
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] Note: Processing compiler hints annotations
> [javac] Note: Writing compiler command file at META-INF/hotspot_compiler
> [javac] Note: Done processing compiler hints annotations
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:22: error: package java.uti
> l.function does not exist
> [javac] import java.util.function.Consumer;
> [javac] ^
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:203: error: cannot find sym
> bol
> [javac] private Consumer<Exception> handler;
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:204: error: cannot find sym
> bol
> [javac] OnException(Consumer<Exception> handler)
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:181: error: cannot find sym
> bol
> [javac] THROW(new Consumer<Exception>()
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:188: error: cannot find sym
> bol
> [javac] LOG(new Consumer<Exception>()
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:195: error: cannot find sym
> bol
> [javac] IGNORE(new Consumer<Exception>()
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac] Note: Some input files use or override a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 6 errors
> [javac] 1 warning
> BUILD FAILED
> /home/mshuler/git/cassandra/build.xml:832: Compile failed; see the compiler error output for details.
> Total time: 42 seconds
> {noformat}
> cc: [~ifesdjeen], [~benedict], [~djoshi3]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org