You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ranganathg (via GitHub)" <gi...@apache.org> on 2023/09/25 16:30:23 UTC
[GitHub] [phoenix] ranganathg commented on a diff in pull request #1686: PHOENIX-7003 Harden hbase region inconsistencies check in CQSI#getAllTableRegions method
ranganathg commented on code in PR #1686:
URL: https://github.com/apache/phoenix/pull/1686#discussion_r1336133609
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -707,7 +707,8 @@ public void clearTableRegionCache(TableName tableName) throws SQLException {
public byte[] getNextRegionStartKey(HRegionLocation regionLocation, byte[] currentKey) throws IOException {
// in order to check the overlap/inconsistencies bad region info, we have to make sure
// the current endKey always increasing(compare the previous endKey)
- if (Bytes.compareTo(regionLocation.getRegion().getEndKey(), currentKey) <= 0
+ if ((Bytes.compareTo(regionLocation.getRegion().getStartKey(), currentKey) != 0
Review Comment:
just trying to understand what does !=0 imply? => startKey could be less than currentKey or greater than currentKey. Is that the real intention or should it specific either less than or greater than?
Also should currentKey be changed to currentEndKey to be inline with the comments and the actual intent of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org