You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alex Jacoby (JIRA)" <ji...@apache.org> on 2008/02/21 16:27:20 UTC

[jira] Created: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

AjaxFormSubmitBehavior doesn't work in Safari
---------------------------------------------

                 Key: WICKET-1362
                 URL: https://issues.apache.org/jira/browse/WICKET-1362
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.1, 1.3.0-final
         Environment: Safari 3.0.4 (OS X)
            Reporter: Alex Jacoby
            Priority: Minor


Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.

Sample code:
public class TestPage extends WebPage {
    private static final long serialVersionUID = 1L;

    private String _text;
    public String getText() { return _text; }
    public void setText(String text) { _text = text; }
    
    public TestPage() {
        Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
        dummyLabel.setOutputMarkupId(true);
        add(dummyLabel);
        
        Form form = new Form("form", new CompoundPropertyModel(this));
        add(form);
        form.add(new TextField("text"));
        form.setOutputMarkupId(true);
        form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
            @Override
            protected void onSubmit(AjaxRequestTarget target) {
                System.out.println("onSubmit!"); // NEVER CALLED!
            }
            @Override
            protected void onError(AjaxRequestTarget target) {
                System.out.println("onError!"); // NEVER CALLED!
            }
            private static final long serialVersionUID = 1L;
        });
    }
}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

Posted by "Alex Jacoby (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576590#action_12576590 ] 

Alex Jacoby commented on WICKET-1362:
-------------------------------------

Here's some html to go with the class:
-- TestPage.html --

<html xmlns="http://www.w3.org/1999/xhtml"
  xmlns:wicket="http://wicket.apache.org/" xml:lang="en" lang="en">

  <head>
      <title>Testing</title>
  </head>
  
  <body>
  <h1>Testing</h1>
  
  <div wicket:id="dummy">[Dummy]</div>
  
  <div>
  <form wicket:id="form">
    Text: <input type="text" wicket:id="text" />
    <input type="submit" />
  </form>
  </div>
  
  </body>

</html>



> AjaxFormSubmitBehavior doesn't work in Safari
> ---------------------------------------------
>
>                 Key: WICKET-1362
>                 URL: https://issues.apache.org/jira/browse/WICKET-1362
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>         Environment: Safari 3.0.4 (OS X)
>            Reporter: Alex Jacoby
>            Priority: Minor
>
> Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.
> Sample code:
> public class TestPage extends WebPage {
>     private static final long serialVersionUID = 1L;
>     private String _text;
>     public String getText() { return _text; }
>     public void setText(String text) { _text = text; }
>     
>     public TestPage() {
>         Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
>         dummyLabel.setOutputMarkupId(true);
>         add(dummyLabel);
>         
>         Form form = new Form("form", new CompoundPropertyModel(this));
>         add(form);
>         form.add(new TextField("text"));
>         form.setOutputMarkupId(true);
>         form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
>             @Override
>             protected void onSubmit(AjaxRequestTarget target) {
>                 System.out.println("onSubmit!"); // NEVER CALLED!
>             }
>             @Override
>             protected void onError(AjaxRequestTarget target) {
>                 System.out.println("onError!"); // NEVER CALLED!
>             }
>             private static final long serialVersionUID = 1L;
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

Posted by "Alex Jacoby (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576793#action_12576793 ] 

Alex Jacoby commented on WICKET-1362:
-------------------------------------

It doesn't say this in the javadocs -- perhaps they could be updated?  Also, the fact that it does work in FF makes it seem like it should be possible.

The benefit to adding it to the form itself, rather than the component, is that you don't need to attach the behavior to multiple components that could submit the form.  Could this be changed to an RFE?  Or is there some inherent reason that makes the desired behavior impossible?

Thanks,
Alex

> AjaxFormSubmitBehavior doesn't work in Safari
> ---------------------------------------------
>
>                 Key: WICKET-1362
>                 URL: https://issues.apache.org/jira/browse/WICKET-1362
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>         Environment: Safari 3.0.4 (OS X)
>            Reporter: Alex Jacoby
>            Assignee: Matej Knopp
>            Priority: Minor
>             Fix For: 1.3.2
>
>
> Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.
> Sample code:
> public class TestPage extends WebPage {
>     private static final long serialVersionUID = 1L;
>     private String _text;
>     public String getText() { return _text; }
>     public void setText(String text) { _text = text; }
>     
>     public TestPage() {
>         Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
>         dummyLabel.setOutputMarkupId(true);
>         add(dummyLabel);
>         
>         Form form = new Form("form", new CompoundPropertyModel(this));
>         add(form);
>         form.add(new TextField("text"));
>         form.setOutputMarkupId(true);
>         form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
>             @Override
>             protected void onSubmit(AjaxRequestTarget target) {
>                 System.out.println("onSubmit!"); // NEVER CALLED!
>             }
>             @Override
>             protected void onError(AjaxRequestTarget target) {
>                 System.out.println("onError!"); // NEVER CALLED!
>             }
>             private static final long serialVersionUID = 1L;
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner reassigned WICKET-1362:
---------------------------------------

    Assignee: Matej Knopp

> AjaxFormSubmitBehavior doesn't work in Safari
> ---------------------------------------------
>
>                 Key: WICKET-1362
>                 URL: https://issues.apache.org/jira/browse/WICKET-1362
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>         Environment: Safari 3.0.4 (OS X)
>            Reporter: Alex Jacoby
>            Assignee: Matej Knopp
>            Priority: Minor
>
> Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.
> Sample code:
> public class TestPage extends WebPage {
>     private static final long serialVersionUID = 1L;
>     private String _text;
>     public String getText() { return _text; }
>     public void setText(String text) { _text = text; }
>     
>     public TestPage() {
>         Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
>         dummyLabel.setOutputMarkupId(true);
>         add(dummyLabel);
>         
>         Form form = new Form("form", new CompoundPropertyModel(this));
>         add(form);
>         form.add(new TextField("text"));
>         form.setOutputMarkupId(true);
>         form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
>             @Override
>             protected void onSubmit(AjaxRequestTarget target) {
>                 System.out.println("onSubmit!"); // NEVER CALLED!
>             }
>             @Override
>             protected void onError(AjaxRequestTarget target) {
>                 System.out.println("onError!"); // NEVER CALLED!
>             }
>             private static final long serialVersionUID = 1L;
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1362:
---------------------------------------

    Fix Version/s:     (was: 1.3.2)

> AjaxFormSubmitBehavior doesn't work in Safari
> ---------------------------------------------
>
>                 Key: WICKET-1362
>                 URL: https://issues.apache.org/jira/browse/WICKET-1362
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>         Environment: Safari 3.0.4 (OS X)
>            Reporter: Alex Jacoby
>            Assignee: Matej Knopp
>            Priority: Minor
>
> Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.
> Sample code:
> public class TestPage extends WebPage {
>     private static final long serialVersionUID = 1L;
>     private String _text;
>     public String getText() { return _text; }
>     public void setText(String text) { _text = text; }
>     
>     public TestPage() {
>         Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
>         dummyLabel.setOutputMarkupId(true);
>         add(dummyLabel);
>         
>         Form form = new Form("form", new CompoundPropertyModel(this));
>         add(form);
>         form.add(new TextField("text"));
>         form.setOutputMarkupId(true);
>         form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
>             @Override
>             protected void onSubmit(AjaxRequestTarget target) {
>                 System.out.println("onSubmit!"); // NEVER CALLED!
>             }
>             @Override
>             protected void onError(AjaxRequestTarget target) {
>                 System.out.println("onError!"); // NEVER CALLED!
>             }
>             private static final long serialVersionUID = 1L;
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp resolved WICKET-1362.
---------------------------------

       Resolution: Invalid
    Fix Version/s: 1.3.2

This is not how AjaxFormSubmitBehavior is supposed to be used. You need to add it to a component that submits form, not to the form itself.

> AjaxFormSubmitBehavior doesn't work in Safari
> ---------------------------------------------
>
>                 Key: WICKET-1362
>                 URL: https://issues.apache.org/jira/browse/WICKET-1362
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>         Environment: Safari 3.0.4 (OS X)
>            Reporter: Alex Jacoby
>            Assignee: Matej Knopp
>            Priority: Minor
>             Fix For: 1.3.2
>
>
> Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.
> Sample code:
> public class TestPage extends WebPage {
>     private static final long serialVersionUID = 1L;
>     private String _text;
>     public String getText() { return _text; }
>     public void setText(String text) { _text = text; }
>     
>     public TestPage() {
>         Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
>         dummyLabel.setOutputMarkupId(true);
>         add(dummyLabel);
>         
>         Form form = new Form("form", new CompoundPropertyModel(this));
>         add(form);
>         form.add(new TextField("text"));
>         form.setOutputMarkupId(true);
>         form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
>             @Override
>             protected void onSubmit(AjaxRequestTarget target) {
>                 System.out.println("onSubmit!"); // NEVER CALLED!
>             }
>             @Override
>             protected void onError(AjaxRequestTarget target) {
>                 System.out.println("onError!"); // NEVER CALLED!
>             }
>             private static final long serialVersionUID = 1L;
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1362) AjaxFormSubmitBehavior doesn't work in Safari

Posted by "Alex Jacoby (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576812#action_12576812 ] 

Alex Jacoby commented on WICKET-1362:
-------------------------------------

Thanks!  Which "fix" do you mean?  Changing the javadocs, or changing the functionality?  I looked at the 1.3.2 source but couldn't figure it out.

> AjaxFormSubmitBehavior doesn't work in Safari
> ---------------------------------------------
>
>                 Key: WICKET-1362
>                 URL: https://issues.apache.org/jira/browse/WICKET-1362
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>         Environment: Safari 3.0.4 (OS X)
>            Reporter: Alex Jacoby
>            Assignee: Matej Knopp
>            Priority: Minor
>
> Create a simple form.  Add an AjaxFormSubmitBehavior to it.  The onSubmit of the AjaxFormSubmitBehavior is never called when using Safari, though it works in FF.
> Sample code:
> public class TestPage extends WebPage {
>     private static final long serialVersionUID = 1L;
>     private String _text;
>     public String getText() { return _text; }
>     public void setText(String text) { _text = text; }
>     
>     public TestPage() {
>         Label dummyLabel = new Label("dummy", new PropertyModel(this, "text"));
>         dummyLabel.setOutputMarkupId(true);
>         add(dummyLabel);
>         
>         Form form = new Form("form", new CompoundPropertyModel(this));
>         add(form);
>         form.add(new TextField("text"));
>         form.setOutputMarkupId(true);
>         form.add(new AjaxFormSubmitBehavior(form, "onsubmit") {
>             @Override
>             protected void onSubmit(AjaxRequestTarget target) {
>                 System.out.println("onSubmit!"); // NEVER CALLED!
>             }
>             @Override
>             protected void onError(AjaxRequestTarget target) {
>                 System.out.println("onError!"); // NEVER CALLED!
>             }
>             private static final long serialVersionUID = 1L;
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.