You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/23 09:48:21 UTC
[GitHub] [arrow-datafusion] ritchie46 opened a new pull request #35: support large-utf8 in groupby
ritchie46 opened a new pull request #35:
URL: https://github.com/apache/arrow-datafusion/pull/35
This PR adds support for `LargeUtf8` in groupby operations.
Administrative question, Do I need to create an addtional issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #35: support large-utf8 in groupby
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #35:
URL: https://github.com/apache/arrow-datafusion/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ritchie46 commented on pull request #35: support large-utf8 in groupby
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #35:
URL: https://github.com/apache/arrow-datafusion/pull/35#issuecomment-825614700
> Looks good @ritchie46 -- thank you!
>
> I think all that is missing is some sort of test that exercises this codepath (to ensure that we don't accidentally break / regress in this functionality in the future)
>
> Perhaps you might following the model of `group_by_dictionary`: https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/execution/context.rs#L1650
Thanks, for pointing me in the direction. I still need to get a bit more familiar with this code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #35: support large-utf8 in groupby
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #35:
URL: https://github.com/apache/arrow-datafusion/pull/35#issuecomment-825591656
> Administrative question, Do I need to create an addtional issue?
Yes, please do -- we are hoping to use issues to create the changelog for each release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #35: support large-utf8 in groupby
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #35:
URL: https://github.com/apache/arrow-datafusion/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org