You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/10/17 13:12:10 UTC

[GitHub] activemq-artemis pull request #2378: ARTEMIS-2131 Error compacting journal

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2378

    ARTEMIS-2131 Error compacting journal

    Compaction cannot free a sliced view of a ByteBuffer on Java >=9:
    the fix is using the original ByteBuffer instead of the slice
    to perform a file write and allow it to be correctly released by
    the Cleaner.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-2131

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2378
    
----
commit 28b75486c7ffa881452bc636e233b71fc5567708
Author: Francesco Nigro <ni...@...>
Date:   2018-10-17T13:10:04Z

    ARTEMIS-2131 Error compacting journal
    
    Compaction cannot free a sliced view of a ByteBuffer on Java >=9:
    the fix is using the original ByteBuffer instead of the slice
    to perform a file write and allow it to be correctly released by
    the Cleaner.

----


---

[GitHub] activemq-artemis issue #2378: ARTEMIS-2131 Error compacting journal

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2378
  
    This PR is addressing just the a change in Java 9 of the Cleaner behaviour: a more complete fix that address the direct memory leak on it would be https://github.com/apache/activemq-artemis/pull/2250.


---

[GitHub] activemq-artemis pull request #2378: ARTEMIS-2131 Error compacting journal

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2378


---