You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/19 06:44:00 UTC
[GitHub] [shardingsphere-on-cloud] xuanyuan300 opened a new pull request, #149: feat(charts): merge operator-charts and operator-cluster-charts.
xuanyuan300 opened a new pull request, #149:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/149
1. Merged operator-charts and operator-cluster-charts, and operator-cluster-chatrs renamed to cluster-operator-charts.
2. Removed webhook code.
3. `ProxySpec` resource type changed from `*v1.ResourceRequirements` to `v1.ResourceRequirements` to fix operator update deployments panic when resource is null
Signed-off-by: xuanyuan300 <xu...@gmail.com>
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] taojintianxia merged pull request #149: feat(charts): merge operator-charts and operator-cluster-charts.
Posted by GitBox <gi...@apache.org>.
taojintianxia merged PR #149:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #149: feat(charts): merge operator-charts and operator-cluster-charts.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #149:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/149#issuecomment-1357221360
# [Codecov](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#149](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21e07bd) into [main](https://codecov.io/gh/apache/shardingsphere-on-cloud/commit/46be6a76c39dbc0160613cf2be9eaedabf6d97b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46be6a7) will **increase** coverage by `13.57%`.
> The diff coverage is `78.43%`.
```diff
@@ Coverage Diff @@
## main #149 +/- ##
===========================================
+ Coverage 62.36% 75.94% +13.57%
===========================================
Files 2 5 +3
Lines 279 291 +12
===========================================
+ Hits 174 221 +47
+ Misses 103 67 -36
- Partials 2 3 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [shardingsphere-operator/pkg/reconcile/resource.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9yZXNvdXJjZS5nbw==) | `25.00% <ø> (-35.08%)` | :arrow_down: |
| [shardingsphere-operator/pkg/reconcile/hpa.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9ocGEuZ28=) | `38.23% <38.23%> (ø)` | |
| [...hardingsphere-operator/pkg/reconcile/deployment.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9kZXBsb3ltZW50Lmdv) | `92.56% <92.56%> (ø)` | |
| [shardingsphere-operator/pkg/reconcile/service.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zZXJ2aWNlLmdv) | `94.87% <94.87%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org