You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 16:43:39 UTC
Review Request 70965: WIP: Test for adding a role in a suppressed
state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70965/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9870
https://issues.apache.org/jira/browse/MESOS-9870
Repository: mesos
Description
-------
WIP: Test for adding a role in a suppressed state.
Diffs
-----
src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
Diff: https://reviews.apache.org/r/70965/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70965: Test for adding a role in a suppressed
state.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70965/#review216208
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master/update_framework_tests.cpp
Lines 620 (patched)
<https://reviews.apache.org/r/70965/#comment303304>
Unused?
- Benjamin Mahler
On June 27, 2019, 7:39 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70965/
> -----------------------------------------------------------
>
> (Updated June 27, 2019, 7:39 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9870
> https://issues.apache.org/jira/browse/MESOS-9870
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test for adding a role in a suppressed state.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
>
>
> Diff: https://reviews.apache.org/r/70965/diff/2/
>
>
> Testing
> -------
>
> without fix: fails
>
> with fix: `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkTest.AddSuppressedRole*" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70965: Test for adding a role in a suppressed
state.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70965/
-----------------------------------------------------------
(Updated June 29, 2019, 12:53 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9870
https://issues.apache.org/jira/browse/MESOS-9870
Repository: mesos
Description
-------
Test for adding a role in a suppressed state.
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
Diff: https://reviews.apache.org/r/70965/diff/3/
Changes: https://reviews.apache.org/r/70965/diff/2-3/
Testing
-------
without fix: fails
with fix: `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkTest.AddSuppressedRole*" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko
Re: Review Request 70965: Test for adding a role in a suppressed
state.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70965/
-----------------------------------------------------------
(Updated June 27, 2019, 7:39 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Summary (updated)
-----------------
Test for adding a role in a suppressed state.
Bugs: MESOS-9870
https://issues.apache.org/jira/browse/MESOS-9870
Repository: mesos
Description (updated)
-------
Test for adding a role in a suppressed state.
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
Diff: https://reviews.apache.org/r/70965/diff/2/
Changes: https://reviews.apache.org/r/70965/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko