[GitHub] [commons-pool] JSurf commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

[GitBox <gi...@apache.org>]

JSurf commented on a change in pull request #67:
URL: https://github.com/apache/commons-pool/pull/67#discussion_r583672713



##########
File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java
##########
@@ -91,6 +91,12 @@
      */
     boolean getLifo();
 
+    /**

Review comment:
       Could easily do, but the class had already a comment that this interface is subject to change:
   
    * NOTE: This interface exists only to define those attributes and methods that
    *       will be made available via JMX. It must not be implemented by clients
    *       as it is subject to change between major, minor and patch version
    *       releases of commons pool. Clients that implement this interface may
    *       not, therefore, be able to upgrade to a new minor or patch release
    *       without requiring code changes.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org