[jira] [Commented] (FLINK-10159) TestHarness#initializeState(xyz) calls after TestHarness#open() are being silently ignored

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582719#comment-16582719 ] 

ASF GitHub Bot commented on FLINK-10159:
----------------------------------------

pnowojski opened a new pull request #6570: [FLINK-10159][tests] Fail TestHarness.initializeState if harness has already been initialized
URL: https://github.com/apache/flink/pull/6570
 
 
   This is a change in tests only. Previously it was technically possible to call first `harness.open()` followed by `harness.initializeState(fooBar)`. However this was incorrect, since `open()` was already calling `initializeState(null)`, which was leading to quirks. This commit adds a `checkState` which makes sure that `initializeState` is called only once.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TestHarness#initializeState(xyz) calls after TestHarness#open() are being silently ignored
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-10159
>                 URL: https://issues.apache.org/jira/browse/FLINK-10159
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.6.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Critical
>              Labels: pull-request-available
>
> This is an old issue. Incorrect order of initializeState and open result to initializeState being ignored. For example in this code:
> {code:java}
> testHarness = createTestHarness(topic);
> testHarness.setup();
> testHarness.open();
> testHarness.initializeState(snapshot1);
> {code}
> Which is miss-leading both for Flink developers and for users (since we recommend using test harness for unit tests).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)