You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/11/11 22:39:24 UTC
Review Request 27884: Alerts: Provide Grouped Summary Structure On
Alerts Endpoint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27884/
-----------------------------------------------------------
Review request for Ambari, Nate Cole, Oleg Nechiporenko, Srimanth Gunturi, and Tom Beerbower.
Bugs: AMBARI-8289
https://issues.apache.org/jira/browse/AMBARI-8289
Repository: ambari
Description
-------
Add ability to get summary info about alerts grouped by {{alert_definition_name}}.
{code}
http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary
{
"alerts_summary_grouped" : [
{
"definition_id" : 1,
"definition_name" : "datanode_process",
"summary" : {
"CRITICAL": {
"count": 1,
"original_timestamp": 1415372992337
},
"OK": {
"count": 1,
"original_timestamp": 1415372992337
},
"UNKNOWN": {
"count": 0,
"original_timestamp": 0
},
"WARN": {
"count": 0,
"original_timestamp": 0
}
}
},
{
"definition_id" : 2,
"definition_name" : "namenode_process",
"summary" : {
"CRITICAL": {
"count": 1,
"original_timestamp": 1415372992337
},
"OK": {
"count": 1,
"original_timestamp": 1415372992337
},
"UNKNOWN": {
"count": 0,
"original_timestamp": 0
},
"WARN": {
"count": 0,
"original_timestamp": 0
}
}
}
]
}
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryRenderer.java afe9798
ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java 18f206e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 3430f8d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 2bac86a
Diff: https://reviews.apache.org/r/27884/diff/
Testing
-------
New test added to cover the new renderer.
Thanks,
Jonathan Hurley
Re: Review Request 27884: Alerts: Provide Grouped Summary Structure On
Alerts Endpoint
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27884/#review60982
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Nov. 11, 2014, 9:41 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27884/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 9:41 p.m.)
>
>
> Review request for Ambari, Nate Cole, Oleg Nechiporenko, Srimanth Gunturi, and Tom Beerbower.
>
>
> Bugs: AMBARI-8289
> https://issues.apache.org/jira/browse/AMBARI-8289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add ability to get summary info about alerts grouped by {{alert_definition_name}}.
>
> ```
> http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary
> {
> "href" : "http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary",
> "alerts_summary_grouped" : [
> {
> "definition_id" : 34,
> "definition_name" : "yarn_resourcemanager_webui",
> "summary" : {
> "OK" : {
> "count" : 1,
> "original_timestamp" : 1415735183450
> },
> "WARNING" : {
> "count" : 0,
> "original_timestamp" : 0
> },
> "CRITICAL" : {
> "count" : 0,
> "original_timestamp" : 0
> },
> "UNKNOWN" : {
> "count" : 0,
> "original_timestamp" : 0
> }
> }
> },
> ...
> ]
> }
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryRenderer.java afe9798
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java 18f206e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 3430f8d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 2bac86a
>
> Diff: https://reviews.apache.org/r/27884/diff/
>
>
> Testing
> -------
>
> New test added to cover the new renderer.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27884: Alerts: Provide Grouped Summary Structure On
Alerts Endpoint
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27884/#review60985
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On Nov. 11, 2014, 9:41 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27884/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 9:41 p.m.)
>
>
> Review request for Ambari, Nate Cole, Oleg Nechiporenko, Srimanth Gunturi, and Tom Beerbower.
>
>
> Bugs: AMBARI-8289
> https://issues.apache.org/jira/browse/AMBARI-8289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add ability to get summary info about alerts grouped by {{alert_definition_name}}.
>
> ```
> http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary
> {
> "href" : "http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary",
> "alerts_summary_grouped" : [
> {
> "definition_id" : 34,
> "definition_name" : "yarn_resourcemanager_webui",
> "summary" : {
> "OK" : {
> "count" : 1,
> "original_timestamp" : 1415735183450
> },
> "WARNING" : {
> "count" : 0,
> "original_timestamp" : 0
> },
> "CRITICAL" : {
> "count" : 0,
> "original_timestamp" : 0
> },
> "UNKNOWN" : {
> "count" : 0,
> "original_timestamp" : 0
> }
> }
> },
> ...
> ]
> }
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryRenderer.java afe9798
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java 18f206e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 3430f8d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 2bac86a
>
> Diff: https://reviews.apache.org/r/27884/diff/
>
>
> Testing
> -------
>
> New test added to cover the new renderer.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27884: Alerts: Provide Grouped Summary Structure On
Alerts Endpoint
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27884/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 4:41 p.m.)
Review request for Ambari, Nate Cole, Oleg Nechiporenko, Srimanth Gunturi, and Tom Beerbower.
Bugs: AMBARI-8289
https://issues.apache.org/jira/browse/AMBARI-8289
Repository: ambari
Description (updated)
-------
Add ability to get summary info about alerts grouped by {{alert_definition_name}}.
```
http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary
{
"href" : "http://localhost:8080/api/v1/clusters/c1/alerts?format=groupedSummary",
"alerts_summary_grouped" : [
{
"definition_id" : 34,
"definition_name" : "yarn_resourcemanager_webui",
"summary" : {
"OK" : {
"count" : 1,
"original_timestamp" : 1415735183450
},
"WARNING" : {
"count" : 0,
"original_timestamp" : 0
},
"CRITICAL" : {
"count" : 0,
"original_timestamp" : 0
},
"UNKNOWN" : {
"count" : 0,
"original_timestamp" : 0
}
}
},
...
]
}
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryRenderer.java afe9798
ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java 18f206e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 3430f8d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java 2bac86a
Diff: https://reviews.apache.org/r/27884/diff/
Testing
-------
New test added to cover the new renderer.
Thanks,
Jonathan Hurley