You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/07/08 12:38:37 UTC

[PR] refactor(configs): fork ShardingConfig for legacy and server-ng [iggy]

hubcio opened a new pull request, #3633:
URL: https://github.com/apache/iggy/pull/3633

   Legacy core/server and server-ng shared one ShardingConfig, coupling
   their config surfaces: server-ng-only knobs (inbox_capacity, shutdown
   and reconcile timers) leaked into legacy, and both read each other's
   static defaults. Since server-ng is meant to replace core/server,
   legacy's config surface must be independently deletable.
   
   Fork the type. Legacy keeps {cpu_allocation, pin_cores}; server-ng
   owns the full six-field type plus its *_MAX bounds and validation.
   SystemConfig becomes generic over the sharding type with the legacy
   variant as the default param, so the legacy server compiles untouched
   and only configs and server-ng need edits. Each server's config.toml
   is now the single source of truth for its defaults.
   
   Making SystemConfig generic exposed the ConfigEnv derive emitting the
   struct name in expression position (SystemConfig::CONST) without
   generics, breaking inference; it now emits the env-var string directly.
   Add struct-level serde(default) on the server-ng type so every field
   falls back to its frozen default, matching the legacy type's behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(configs): fork ShardingConfig for legacy and server-ng [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3633:
URL: https://github.com/apache/iggy/pull/3633#issuecomment-4914862200

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3633?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 72.75%. Comparing base ([`ebaffde`](https://app.codecov.io/gh/apache/iggy/commit/ebaffde44afb46f792a512a044ec7553c922faf2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b16b8e0`](https://app.codecov.io/gh/apache/iggy/commit/b16b8e0595dbf3bd6701c7be48aaae06e6220197?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3633      +/-   ##
   ============================================
   - Coverage     73.49%   72.75%   -0.75%     
     Complexity      937      937              
   ============================================
     Files          1282     1219      -63     
     Lines        138754   133892    -4862     
     Branches     114643   114380     -263     
   ============================================
   - Hits         101978    97407    -4571     
   + Misses        33599    33308     -291     
     Partials       3177     3177              
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.73% <ø> (-0.02%)` | :arrow_down: |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.44% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.10% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.65% <ø> (ø)` | |
   | [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.29% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.27% <ø> (-3.95%)` | :arrow_down: |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3633/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.28% <ø> (ø)` | |
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3633?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [core/configs/src/server\_config/defaults.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fdefaults.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL2RlZmF1bHRzLnJz) | `77.55% <ø> (-0.16%)` | :arrow_down: |
   | [core/configs/src/server\_config/displays.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fdisplays.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL2Rpc3BsYXlzLnJz) | `93.04% <ø> (ø)` | |
   | [core/configs/src/server\_config/sharding.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fsharding.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL3NoYXJkaW5nLnJz) | `100.00% <ø> (ø)` | |
   | [core/configs/src/server\_config/system.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fsystem.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL3N5c3RlbS5ycw==) | `95.51% <ø> (ø)` | |
   | [core/configs/src/server\_config/validators.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fvalidators.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL3ZhbGlkYXRvcnMucnM=) | `79.48% <ø> (-1.33%)` | :arrow_down: |
   | [core/configs/src/server\_ng\_config/defaults.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_ng_config%2Fdefaults.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfbmdfY29uZmlnL2RlZmF1bHRzLnJz) | `100.00% <ø> (ø)` | |
   | [core/configs/src/server\_ng\_config/server\_ng.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_ng_config%2Fserver_ng.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfbmdfY29uZmlnL3NlcnZlcl9uZy5ycw==) | `47.05% <ø> (ø)` | |
   | [core/configs\_derive/src/config\_env.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fconfigs_derive%2Fsrc%2Fconfig_env.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzX2Rlcml2ZS9zcmMvY29uZmlnX2Vudi5ycw==) | `93.19% <ø> (-0.20%)` | :arrow_down: |
   | [core/server-ng/src/bootstrap.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fbootstrap.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2Jvb3RzdHJhcC5ycw==) | `10.47% <ø> (+0.01%)` | :arrow_up: |
   | [core/server-ng/src/dispatch.rs](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fdispatch.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2Rpc3BhdGNoLnJz) | `0.00% <ø> (ø)` | |
   | ... and [4 more](https://app.codecov.io/gh/apache/iggy/pull/3633?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [81 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3633/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(configs): fork ShardingConfig for legacy and server-ng [iggy]

Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #3633:
URL: https://github.com/apache/iggy/pull/3633


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org