[jira] [Commented] (PROTON-940) provide the session initial incoming window via Begin rather than sending a separate Flow

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621372#comment-14621372 ] 

ASF subversion and git services commented on PROTON-940:
--------------------------------------------------------

Commit 2b41931dbb49730ddba92c42e40113899371c2d7 in qpid-proton's branch refs/heads/cjansen-cpp-client from Robert Gemmell
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2b41931 ]

PROTON-940: calculate the incoming window before sending the Begin frame to ensure it is initialised, which supresses the need for a subsequent Flow as seen previously


> provide the session initial incoming window via Begin rather than sending a separate Flow
> -----------------------------------------------------------------------------------------
>
>                 Key: PROTON-940
>                 URL: https://issues.apache.org/jira/browse/PROTON-940
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: 0.8, 0.9, 0.9.1
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.10
>
>         Attachments: 0001-PROTON-940-calculate-the-incoming-window-before-send.patch
>
>
> When a session is created, a Begin frame is sent. One of the fields on the frame is the initial incoming window. Instead of populating the field, Proton-J currently sets it to 0 but then immediately discovers the window is 0 and sends a seperate Flow frame (in the same transport output sas the Begin frame) changing the window to the actual calculated value.
> This result is equivalent in the end and allowed by the protocol, but is not particularly obvious behaviour and is different than proton-c. The initial incoming window value should be conveyed in the Begin frame instead, removing need for the immediate Flow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)