You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2015/09/29 01:22:08 UTC
Review Request 38830: RANGER-664:Ranger PolicyRefresh REST Client
timeout parameter should be configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38830/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
Repository: ranger
Description
-------
RANGER-664:Ranger PolicyRefresh REST Client timeout parameter should be configurable
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 46fab40
hbase-agent/conf/ranger-hbase-security-changes.cfg 9c74898
hbase-agent/conf/ranger-hbase-security.xml 43d5d36
hdfs-agent/conf/ranger-hdfs-security-changes.cfg 4bdb08f
hdfs-agent/conf/ranger-hdfs-security.xml 37230b7
hive-agent/conf/ranger-hive-security-changes.cfg 504bf7d
hive-agent/conf/ranger-hive-security.xml 010debc
knox-agent/conf/ranger-knox-security-changes.cfg 8fb8a7b
knox-agent/conf/ranger-knox-security.xml 8e442e9
plugin-kafka/conf/ranger-kafka-security-changes.cfg fe36616
plugin-kafka/conf/ranger-kafka-security.xml b11a71a
plugin-kms/conf/ranger-kms-security-changes.cfg fdd1723
plugin-kms/conf/ranger-kms-security.xml 3aae5f1
plugin-solr/conf/ranger-solr-security-changes.cfg ed8a509
plugin-solr/conf/ranger-solr-security.xml c865749
plugin-yarn/conf/ranger-yarn-security-changes.cfg 87fa972
plugin-yarn/conf/ranger-yarn-security.xml f6e37f8
storm-agent/conf/ranger-storm-security-changes.cfg 9d3ca13
storm-agent/conf/ranger-storm-security.xml 9126fc9
Diff: https://reviews.apache.org/r/38830/diff/
Testing
-------
Tested locally in Sandbox
Thanks,
Ramesh Mani
Re: Review Request 38830: RANGER-664:Ranger PolicyRefresh REST Client
timeout parameter should be configurable
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38830/#review100898
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java (line 86)
<https://reviews.apache.org/r/38830/#comment158150>
Instead of hardcoding the properties here, in RangerRESTClient.java, provide following setter methods: setConnectionTimeoutMs(), setReadTimeoutMs(). And have these methods be called by the users of this class.
This is to be consitent with the configuration/property name convention, where the plugin type is part of the name. That is:
ranger.policy.rest.client.connection.timeoutMs ==> ranger.plugin.hdfs.policy.rest.client.connection.timeoutMs
Please review all such references.
- Madhan Neethiraj
On Sept. 28, 2015, 11:22 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38830/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 11:22 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-664:Ranger PolicyRefresh REST Client timeout parameter should be configurable
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 46fab40
> hbase-agent/conf/ranger-hbase-security-changes.cfg 9c74898
> hbase-agent/conf/ranger-hbase-security.xml 43d5d36
> hdfs-agent/conf/ranger-hdfs-security-changes.cfg 4bdb08f
> hdfs-agent/conf/ranger-hdfs-security.xml 37230b7
> hive-agent/conf/ranger-hive-security-changes.cfg 504bf7d
> hive-agent/conf/ranger-hive-security.xml 010debc
> knox-agent/conf/ranger-knox-security-changes.cfg 8fb8a7b
> knox-agent/conf/ranger-knox-security.xml 8e442e9
> plugin-kafka/conf/ranger-kafka-security-changes.cfg fe36616
> plugin-kafka/conf/ranger-kafka-security.xml b11a71a
> plugin-kms/conf/ranger-kms-security-changes.cfg fdd1723
> plugin-kms/conf/ranger-kms-security.xml 3aae5f1
> plugin-solr/conf/ranger-solr-security-changes.cfg ed8a509
> plugin-solr/conf/ranger-solr-security.xml c865749
> plugin-yarn/conf/ranger-yarn-security-changes.cfg 87fa972
> plugin-yarn/conf/ranger-yarn-security.xml f6e37f8
> storm-agent/conf/ranger-storm-security-changes.cfg 9d3ca13
> storm-agent/conf/ranger-storm-security.xml 9126fc9
>
> Diff: https://reviews.apache.org/r/38830/diff/
>
>
> Testing
> -------
>
> Tested locally in Sandbox
>
>
> Thanks,
>
> Ramesh Mani
>
>