You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by "Skalicky, Sam" <ss...@amazon.com.INVALID> on 2021/01/22 20:12:35 UTC
[VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Dear community,
This is a call for a releasing Apache MXNet (incubating) 1.8.0, release candidate 3.
Apache MXNet (incubating) community has voted and approved the release.
Vote thread:
https://lists.apache.org/thread.html/r42511b3c24a6df9f07a502dd0afd9db514b2592c30c26b90ffbd36ce%40%3Cdev.mxnet.apache.org%3E
Result thread:
https://lists.apache.org/thread.html/r4aa42956b2a9c417e10043dd12a16e926d0a11e8b0e7befeac3fb242%40%3Cdev.mxnet.apache.org%3E
The source tarball, including signatures, digests, etc. can be found at:
https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc3
The tag to be voted upon is 1.8.0.rc3:
https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc3
The release hash is 2fc0706874531fdfdbe49819eae0c88f8016eee3:
https://github.com/apache/incubator-mxnet/commit/2fc0706874531fdfdbe49819eae0c88f8016eee3
KEYS file available:
https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
For information about the contents of this release, see:
https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes
Here are the changes comparing to 1.8.0.rc2:
* Updated LICENSE & rat checker
* Extensions bugfixes
* fix for R builds
* Upgrade to oneDNN v1.7 with required bugfixes
* Fix for testing with CUDA 11, remove cleanup on side threads
* Fix for building CUDA 11 with Windows
* Remove temporary fix for RNN in MKLDNN
The vote will be open for 72 hours.
[ ] +1 release this package as #########
[ ] +0 no opinion
[ ] -1 do not release this package because...
Best regards,
Sam Skalicky
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Sam Skalicky <sa...@apache.org>.
Thanks for the vote & feedback Jason & Paul, we'll address these in the next release.
Sam
On 2021/03/02 03:53:26, Paul King <pa...@asert.com.au> wrote:
> +1 (binding)
>
> Checked:
> - LICENSE and NOTICE seem okay
> - DISCLAIMER-WIP exists
> - Incubating in name
> - Checksum and signature okay
> - No unexpected binary file
> - Built shared library using cmake (without CUDA)
> - Built Java/Scala jars (also works for Groovy)
>
> Comments:
> * As others have noted, please fix LICENSE, NOTICE and DISCLAIMER-WIP files
> moving forward.
> * LICENSE file mentions 3rdparty/tvm/3rdparty/rang as "Unlicense". It would
> be good to clarify that.
> * Also a minor thing which could be improved: "What's New" section in
> README.md stops at version 1.5.1. It would be great to keep that section
> updated or point to some website if that info is elsewhere.
> * You reference KEYS in dev space but also have one in the release space
> at: https://dist.apache.org/repos/dist/release/incubator/mxnet/. I'd
> encourage you just to use the release one (keeping it updated as needed)
> and delete the dev one. This would avoid having two (potentially out of
> sync) sources of truth.
> * I had to manually copy some .a/.so files from root directory to lib (I
> could have done a step wrong)
> * I had to use JDK8 to build jars (didn't see that in instructions I was
> following but I could have missed it)
> * Built jars had version INTERNAL, I was expecting 1.8.0.rc3 or similar
> * I was planning to run my Groovy data science example against the jar but
> the produced jars didn't seem complete (perhaps my lack of understanding of
> steps required)
>
> Cheers, Paul.
>
> On Mon, Jan 25, 2021 at 12:37 AM Skalicky, Sam <ss...@amazon.com.invalid>
> wrote:
>
> > Dear community,
> >
> > This is a call for a releasing Apache MXNet (incubating) 1.8.0, release
> > candidate 3.
> >
> > Apache MXNet (incubating) community has voted and approved the release.
> >
> > Vote thread:
> >
> > https://lists.apache.org/thread.html/r42511b3c24a6df9f07a502dd0afd9db514b2592c30c26b90ffbd36ce%40%3Cdev.mxnet.apache.org%3E
> >
> > Result thread:
> >
> > https://lists.apache.org/thread.html/r4aa42956b2a9c417e10043dd12a16e926d0a11e8b0e7befeac3fb242%40%3Cdev.mxnet.apache.org%3E
> >
> > The source tarball, including signatures, digests, etc. can be found at:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc3
> >
> > The tag to be voted upon is 1.8.0.rc3:
> > https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc3
> >
> > The release hash is 2fc0706874531fdfdbe49819eae0c88f8016eee3:
> >
> > https://github.com/apache/incubator-mxnet/commit/2fc0706874531fdfdbe49819eae0c88f8016eee3
> >
> > KEYS file available:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> >
> > For information about the contents of this release, see:
> > https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes
> >
> > Here are the changes comparing to 1.8.0.rc2:
> > * Updated LICENSE & rat checker
> > * Extensions bugfixes
> > * fix for R builds
> > * Upgrade to oneDNN v1.7 with required bugfixes
> > * Fix for testing with CUDA 11, remove cleanup on side threads
> > * Fix for building CUDA 11 with Windows
> > * Remove temporary fix for RNN in MKLDNN
> >
> > The vote will be open for 72 hours.
> > [ ] +1 release this package as #########
> > [ ] +0 no opinion
> > [ ] -1 do not release this package because...
> >
> > Best regards,
> > Sam Skalicky
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Paul King <pa...@asert.com.au>.
That makes sense. I equated "Unlicense" with the informal English usage of
"unlicensed" at first glance.
A possible improvement might be to use "Public domain (unlicense.org)"
instead of "Unlicense"
but perhaps others are more aware of that reference.
Cheers, Paul.
On Wed, Mar 3, 2021 at 7:34 AM Leonard Lausen <la...@apache.org> wrote:
> Thank you Paul for voting on the release.
>
> On 2021/03/02 03:53:26, Paul King <pa...@asert.com.au> wrote:
>
> > * LICENSE file mentions 3rdparty/tvm/3rdparty/rang as "Unlicense". It
> would
> > be good to clarify that.
>
> You can refer to line 207-211 in our LICENSE file, which state that the the
> license of each subcomponent is available at the path of the subcomponent
> as
> long as nothing else is noted in our LICENSE file. So in the case of
> 3rdparty/tvm/3rdparty/rang, we request our users to take a look at
> 3rdparty/tvm/3rdparty/rang folder and open
> 3rdparty/tvm/3rdparty/rang/LICENSE
> to find the license text of the Unlicense.
>
> Best regards
> Leonard
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Leonard Lausen <la...@apache.org>.
Thank you Paul for voting on the release.
On 2021/03/02 03:53:26, Paul King <pa...@asert.com.au> wrote:
> * LICENSE file mentions 3rdparty/tvm/3rdparty/rang as "Unlicense". It would
> be good to clarify that.
You can refer to line 207-211 in our LICENSE file, which state that the the
license of each subcomponent is available at the path of the subcomponent as
long as nothing else is noted in our LICENSE file. So in the case of
3rdparty/tvm/3rdparty/rang, we request our users to take a look at
3rdparty/tvm/3rdparty/rang folder and open 3rdparty/tvm/3rdparty/rang/LICENSE
to find the license text of the Unlicense.
Best regards
Leonard
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Paul King <pa...@asert.com.au>.
+1 (binding)
Checked:
- LICENSE and NOTICE seem okay
- DISCLAIMER-WIP exists
- Incubating in name
- Checksum and signature okay
- No unexpected binary file
- Built shared library using cmake (without CUDA)
- Built Java/Scala jars (also works for Groovy)
Comments:
* As others have noted, please fix LICENSE, NOTICE and DISCLAIMER-WIP files
moving forward.
* LICENSE file mentions 3rdparty/tvm/3rdparty/rang as "Unlicense". It would
be good to clarify that.
* Also a minor thing which could be improved: "What's New" section in
README.md stops at version 1.5.1. It would be great to keep that section
updated or point to some website if that info is elsewhere.
* You reference KEYS in dev space but also have one in the release space
at: https://dist.apache.org/repos/dist/release/incubator/mxnet/. I'd
encourage you just to use the release one (keeping it updated as needed)
and delete the dev one. This would avoid having two (potentially out of
sync) sources of truth.
* I had to manually copy some .a/.so files from root directory to lib (I
could have done a step wrong)
* I had to use JDK8 to build jars (didn't see that in instructions I was
following but I could have missed it)
* Built jars had version INTERNAL, I was expecting 1.8.0.rc3 or similar
* I was planning to run my Groovy data science example against the jar but
the produced jars didn't seem complete (perhaps my lack of understanding of
steps required)
Cheers, Paul.
On Mon, Jan 25, 2021 at 12:37 AM Skalicky, Sam <ss...@amazon.com.invalid>
wrote:
> Dear community,
>
> This is a call for a releasing Apache MXNet (incubating) 1.8.0, release
> candidate 3.
>
> Apache MXNet (incubating) community has voted and approved the release.
>
> Vote thread:
>
> https://lists.apache.org/thread.html/r42511b3c24a6df9f07a502dd0afd9db514b2592c30c26b90ffbd36ce%40%3Cdev.mxnet.apache.org%3E
>
> Result thread:
>
> https://lists.apache.org/thread.html/r4aa42956b2a9c417e10043dd12a16e926d0a11e8b0e7befeac3fb242%40%3Cdev.mxnet.apache.org%3E
>
> The source tarball, including signatures, digests, etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc3
>
> The tag to be voted upon is 1.8.0.rc3:
> https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc3
>
> The release hash is 2fc0706874531fdfdbe49819eae0c88f8016eee3:
>
> https://github.com/apache/incubator-mxnet/commit/2fc0706874531fdfdbe49819eae0c88f8016eee3
>
> KEYS file available:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>
> For information about the contents of this release, see:
> https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes
>
> Here are the changes comparing to 1.8.0.rc2:
> * Updated LICENSE & rat checker
> * Extensions bugfixes
> * fix for R builds
> * Upgrade to oneDNN v1.7 with required bugfixes
> * Fix for testing with CUDA 11, remove cleanup on side threads
> * Fix for building CUDA 11 with Windows
> * Remove temporary fix for RNN in MKLDNN
>
> The vote will be open for 72 hours.
> [ ] +1 release this package as #########
> [ ] +0 no opinion
> [ ] -1 do not release this package because...
>
> Best regards,
> Sam Skalicky
>
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Jason Dai <ja...@gmail.com>.
+1 (binding); I checked:
- LICENSE and NOTICE exist
- DISCLAIMER-WIP exists
- Incubating in name
- Checksum correct
- No unexpected binary
Please fix LICENSE and DISCLAIMER-WIP.
Thanks,
-Jason
On Fri, Feb 26, 2021 at 8:59 AM Craig Russell <ap...@gmail.com> wrote:
> Hi Sheng,
>
> The first place I would suggest you to ask is your mentors. Next, your
> PPMC members who are IPMC members.
>
> Hope this helps,
> Craig
>
> > On Feb 25, 2021, at 1:21 PM, Sheng Zha <sz...@gmail.com> wrote:
> >
> > Bumping this thread up. Thanks to those who helped with the vote.
> >
> > So far, our 1.8 vote has received 2 binding votes from general@, one
> > from Justin and one from our new mentor Furkan. Since this vote has
> > been open for a month, I wonder if there's any suggestion from people
> > on the list on how we can improve engagement.
> >
> > Thanks,
> > Sheng
> >
> > On Wed, Feb 10, 2021 at 4:07 AM Furkan KAMACI <fu...@gmail.com>
> wrote:
> >>
> >> Hi,
> >>
> >> +1 from me (binding).
> >>
> >> I checked:
> >>
> >> - Incubating in name
> >> - DISCLAIMER-WIP exists
> >> - LICENSE is fine
> >> - NOTICE has incorrect year
> >> - No unexpected binary files
> >> - Checked PGP signatures
> >> - Checked checksums
> >> - Code compiles and tests successfully run
> >>
> >> PS: DISCLAIMER-WIP/LICENSE should be fixed as Justin mentioned.
> >>
> >> Kind Regards,
> >> Furkan KAMACI
> >>
> >> On Tue, Feb 9, 2021 at 8:15 PM Sam Skalicky <sa...@apache.org>
> wrote:
> >>
> >>> Hi Mentors,
> >>>
> >>> Please help us get out this release by voting. Thanks for helping
> MXNet as
> >>> it grows in the incubator.
> >>>
> >>> Thanks!
> >>> Sam
> >>>
> >>> On 2021/02/01 18:52:24, Sam Skalicky <sa...@apache.org> wrote:
> >>>> Thanks Justin,
> >>>>
> >>>> We'll take note of these callouts and address them in the next
> release.
> >>>>
> >>>> Sam
> >>>>
> >>>> On 2021/01/28 03:38:37, Justin Mclean <ju...@classsoftware.com>
> wrote:
> >>>>> Hi,
> >>>>>
> >>>>> +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not
> >>> correct and source release contains Category B licensed bits.
> >>>>>
> >>>>> I checked:
> >>>>> - incubating in name
> >>>>> - signatures and hashes are fine
> >>>>> - DISCLAIMER (WIP) exist but information has not been updated in it
> >>>>> - LICENSE looks OK but I’ve not checked everything and there looks
> >>> like there been a lot of changes since the last release. It missing
> some
> >>> 3rd party licenses.
> >>>>> - NOTICE has incorrect year
> >>>>> - The source include a font under the OFL license In general this
> >>> can't be included in a source release. [1] This should be mention in
> the
> >>> DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
> >>>>> - It would be good to see more description in the rat exclusions file
> >>> (and have it at the top level)
> >>>>> - No unexpected binary files. However I did seem some binary files
> >>> that should be mentioned in LICENSE. [2][3][4][5][6][7]
> >>>>> - It also unclear how [2] is licensed and may be category X
> >>>>> - I didn’t try to compile from source
> >>>>>
> >>>>> Thanks,
> >>>>> Justin
> >>>>>
> >>>>>
> >>>>> 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> >>>>> 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
> >>>>> 3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
> >>>>> 4.
> ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
> >>>>> 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
> >>>>> 6.
> >>>
> ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
> >>>>> 7.
> /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
> >>>>>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>>>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>>>
> >>>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>>
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >>>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
> Craig L Russell
> clr@apache.org
>
>
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Craig Russell <ap...@gmail.com>.
Hi Sheng,
The first place I would suggest you to ask is your mentors. Next, your PPMC members who are IPMC members.
Hope this helps,
Craig
> On Feb 25, 2021, at 1:21 PM, Sheng Zha <sz...@gmail.com> wrote:
>
> Bumping this thread up. Thanks to those who helped with the vote.
>
> So far, our 1.8 vote has received 2 binding votes from general@, one
> from Justin and one from our new mentor Furkan. Since this vote has
> been open for a month, I wonder if there's any suggestion from people
> on the list on how we can improve engagement.
>
> Thanks,
> Sheng
>
> On Wed, Feb 10, 2021 at 4:07 AM Furkan KAMACI <fu...@gmail.com> wrote:
>>
>> Hi,
>>
>> +1 from me (binding).
>>
>> I checked:
>>
>> - Incubating in name
>> - DISCLAIMER-WIP exists
>> - LICENSE is fine
>> - NOTICE has incorrect year
>> - No unexpected binary files
>> - Checked PGP signatures
>> - Checked checksums
>> - Code compiles and tests successfully run
>>
>> PS: DISCLAIMER-WIP/LICENSE should be fixed as Justin mentioned.
>>
>> Kind Regards,
>> Furkan KAMACI
>>
>> On Tue, Feb 9, 2021 at 8:15 PM Sam Skalicky <sa...@apache.org> wrote:
>>
>>> Hi Mentors,
>>>
>>> Please help us get out this release by voting. Thanks for helping MXNet as
>>> it grows in the incubator.
>>>
>>> Thanks!
>>> Sam
>>>
>>> On 2021/02/01 18:52:24, Sam Skalicky <sa...@apache.org> wrote:
>>>> Thanks Justin,
>>>>
>>>> We'll take note of these callouts and address them in the next release.
>>>>
>>>> Sam
>>>>
>>>> On 2021/01/28 03:38:37, Justin Mclean <ju...@classsoftware.com> wrote:
>>>>> Hi,
>>>>>
>>>>> +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not
>>> correct and source release contains Category B licensed bits.
>>>>>
>>>>> I checked:
>>>>> - incubating in name
>>>>> - signatures and hashes are fine
>>>>> - DISCLAIMER (WIP) exist but information has not been updated in it
>>>>> - LICENSE looks OK but I’ve not checked everything and there looks
>>> like there been a lot of changes since the last release. It missing some
>>> 3rd party licenses.
>>>>> - NOTICE has incorrect year
>>>>> - The source include a font under the OFL license In general this
>>> can't be included in a source release. [1] This should be mention in the
>>> DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
>>>>> - It would be good to see more description in the rat exclusions file
>>> (and have it at the top level)
>>>>> - No unexpected binary files. However I did seem some binary files
>>> that should be mentioned in LICENSE. [2][3][4][5][6][7]
>>>>> - It also unclear how [2] is licensed and may be category X
>>>>> - I didn’t try to compile from source
>>>>>
>>>>> Thanks,
>>>>> Justin
>>>>>
>>>>>
>>>>> 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
>>>>> 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
>>>>> 3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
>>>>> 4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
>>>>> 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
>>>>> 6.
>>> ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
>>>>> 7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
Craig L Russell
clr@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Sheng Zha <sz...@gmail.com>.
Bumping this thread up. Thanks to those who helped with the vote.
So far, our 1.8 vote has received 2 binding votes from general@, one
from Justin and one from our new mentor Furkan. Since this vote has
been open for a month, I wonder if there's any suggestion from people
on the list on how we can improve engagement.
Thanks,
Sheng
On Wed, Feb 10, 2021 at 4:07 AM Furkan KAMACI <fu...@gmail.com> wrote:
>
> Hi,
>
> +1 from me (binding).
>
> I checked:
>
> - Incubating in name
> - DISCLAIMER-WIP exists
> - LICENSE is fine
> - NOTICE has incorrect year
> - No unexpected binary files
> - Checked PGP signatures
> - Checked checksums
> - Code compiles and tests successfully run
>
> PS: DISCLAIMER-WIP/LICENSE should be fixed as Justin mentioned.
>
> Kind Regards,
> Furkan KAMACI
>
> On Tue, Feb 9, 2021 at 8:15 PM Sam Skalicky <sa...@apache.org> wrote:
>
> > Hi Mentors,
> >
> > Please help us get out this release by voting. Thanks for helping MXNet as
> > it grows in the incubator.
> >
> > Thanks!
> > Sam
> >
> > On 2021/02/01 18:52:24, Sam Skalicky <sa...@apache.org> wrote:
> > > Thanks Justin,
> > >
> > > We'll take note of these callouts and address them in the next release.
> > >
> > > Sam
> > >
> > > On 2021/01/28 03:38:37, Justin Mclean <ju...@classsoftware.com> wrote:
> > > > Hi,
> > > >
> > > > +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not
> > correct and source release contains Category B licensed bits.
> > > >
> > > > I checked:
> > > > - incubating in name
> > > > - signatures and hashes are fine
> > > > - DISCLAIMER (WIP) exist but information has not been updated in it
> > > > - LICENSE looks OK but I’ve not checked everything and there looks
> > like there been a lot of changes since the last release. It missing some
> > 3rd party licenses.
> > > > - NOTICE has incorrect year
> > > > - The source include a font under the OFL license In general this
> > can't be included in a source release. [1] This should be mention in the
> > DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
> > > > - It would be good to see more description in the rat exclusions file
> > (and have it at the top level)
> > > > - No unexpected binary files. However I did seem some binary files
> > that should be mentioned in LICENSE. [2][3][4][5][6][7]
> > > > - It also unclear how [2] is licensed and may be category X
> > > > - I didn’t try to compile from source
> > > >
> > > > Thanks,
> > > > Justin
> > > >
> > > >
> > > > 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > > > 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
> > > > 3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
> > > > 4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
> > > > 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
> > > > 6.
> > ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
> > > > 7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: general-help@incubator.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me (binding).
I checked:
- Incubating in name
- DISCLAIMER-WIP exists
- LICENSE is fine
- NOTICE has incorrect year
- No unexpected binary files
- Checked PGP signatures
- Checked checksums
- Code compiles and tests successfully run
PS: DISCLAIMER-WIP/LICENSE should be fixed as Justin mentioned.
Kind Regards,
Furkan KAMACI
On Tue, Feb 9, 2021 at 8:15 PM Sam Skalicky <sa...@apache.org> wrote:
> Hi Mentors,
>
> Please help us get out this release by voting. Thanks for helping MXNet as
> it grows in the incubator.
>
> Thanks!
> Sam
>
> On 2021/02/01 18:52:24, Sam Skalicky <sa...@apache.org> wrote:
> > Thanks Justin,
> >
> > We'll take note of these callouts and address them in the next release.
> >
> > Sam
> >
> > On 2021/01/28 03:38:37, Justin Mclean <ju...@classsoftware.com> wrote:
> > > Hi,
> > >
> > > +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not
> correct and source release contains Category B licensed bits.
> > >
> > > I checked:
> > > - incubating in name
> > > - signatures and hashes are fine
> > > - DISCLAIMER (WIP) exist but information has not been updated in it
> > > - LICENSE looks OK but I’ve not checked everything and there looks
> like there been a lot of changes since the last release. It missing some
> 3rd party licenses.
> > > - NOTICE has incorrect year
> > > - The source include a font under the OFL license In general this
> can't be included in a source release. [1] This should be mention in the
> DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
> > > - It would be good to see more description in the rat exclusions file
> (and have it at the top level)
> > > - No unexpected binary files. However I did seem some binary files
> that should be mentioned in LICENSE. [2][3][4][5][6][7]
> > > - It also unclear how [2] is licensed and may be category X
> > > - I didn’t try to compile from source
> > >
> > > Thanks,
> > > Justin
> > >
> > >
> > > 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > > 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
> > > 3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
> > > 4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
> > > 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
> > > 6.
> ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
> > > 7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Sam Skalicky <sa...@apache.org>.
Hi Mentors,
Please help us get out this release by voting. Thanks for helping MXNet as it grows in the incubator.
Thanks!
Sam
On 2021/02/01 18:52:24, Sam Skalicky <sa...@apache.org> wrote:
> Thanks Justin,
>
> We'll take note of these callouts and address them in the next release.
>
> Sam
>
> On 2021/01/28 03:38:37, Justin Mclean <ju...@classsoftware.com> wrote:
> > Hi,
> >
> > +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not correct and source release contains Category B licensed bits.
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes are fine
> > - DISCLAIMER (WIP) exist but information has not been updated in it
> > - LICENSE looks OK but I’ve not checked everything and there looks like there been a lot of changes since the last release. It missing some 3rd party licenses.
> > - NOTICE has incorrect year
> > - The source include a font under the OFL license In general this can't be included in a source release. [1] This should be mention in the DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
> > - It would be good to see more description in the rat exclusions file (and have it at the top level)
> > - No unexpected binary files. However I did seem some binary files that should be mentioned in LICENSE. [2][3][4][5][6][7]
> > - It also unclear how [2] is licensed and may be category X
> > - I didn’t try to compile from source
> >
> > Thanks,
> > Justin
> >
> >
> > 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
> > 3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
> > 4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
> > 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
> > 6. ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
> > 7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Sam Skalicky <sa...@apache.org>.
Thanks Justin,
We'll take note of these callouts and address them in the next release.
Sam
On 2021/01/28 03:38:37, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
> +1 (binding) but only because of WIP DISCLAIMER. LICENSE is not correct and source release contains Category B licensed bits.
>
> I checked:
> - incubating in name
> - signatures and hashes are fine
> - DISCLAIMER (WIP) exist but information has not been updated in it
> - LICENSE looks OK but I’ve not checked everything and there looks like there been a lot of changes since the last release. It missing some 3rd party licenses.
> - NOTICE has incorrect year
> - The source include a font under the OFL license In general this can't be included in a source release. [1] This should be mention in the DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
> - It would be good to see more description in the rat exclusions file (and have it at the top level)
> - No unexpected binary files. However I did seem some binary files that should be mentioned in LICENSE. [2][3][4][5][6][7]
> - It also unclear how [2] is licensed and may be category X
> - I didn’t try to compile from source
>
> Thanks,
> Justin
>
>
> 1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> 2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
> 3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
> 4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
> 5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
> 6. ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
> 7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc3
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 (binding) but only because of WIP DISCLAIMER. LICENSE is not correct and source release contains Category B licensed bits.
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER (WIP) exist but information has not been updated in it
- LICENSE looks OK but I’ve not checked everything and there looks like there been a lot of changes since the last release. It missing some 3rd party licenses.
- NOTICE has incorrect year
- The source include a font under the OFL license In general this can't be included in a source release. [1] This should be mention in the DISCLAIMER. Also [4] and [7] are under the OFL license I believe.
- It would be good to see more description in the rat exclusions file (and have it at the top level)
- No unexpected binary files. However I did seem some binary files that should be mentioned in LICENSE. [2][3][4][5][6][7]
- It also unclear how [2] is licensed and may be category X
- I didn’t try to compile from source
Thanks,
Justin
1 https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
2. ./3rdparty/mkldnn/doc/assets/fonts/fontawesome-webfont*
3. ./3rdparty/mkldnn/doc/assets/fonts/lato*
4. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/Asana-Math/otf*
5. ./3rdparty/mkldnn/doc/assets/mathjax/fonts/HTML-CSS/*/*/MathJax*
6. ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/*
7. /docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid*
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org