You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Daniel Santos (JIRA)" <ji...@apache.org> on 2009/01/12 18:46:01 UTC
[jira] Created: (FTPSERVER-262) FileSystemView.dispose() is never
called
FileSystemView.dispose() is never called
----------------------------------------
Key: FTPSERVER-262
URL: https://issues.apache.org/jira/browse/FTPSERVER-262
Project: FtpServer
Issue Type: Bug
Components: Ftplets
Affects Versions: 1.0.0-M4
Reporter: Daniel Santos
The FileSystemView.dispose() function is never called.
This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "Niklas Therning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663265#action_12663265 ]
Niklas Therning commented on FTPSERVER-262:
-------------------------------------------
I can confirm that this bug exists also in the 1.0.0-RC1 code currently being in vote. Maybe a fix is needed before RC1 is released?
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson updated FTPSERVER-262:
----------------------------------------
Fix Version/s: 1.0.0-RC2
Assignee: Niklas Gustavsson
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
> Assignee: Niklas Gustavsson
> Fix For: 1.0.0-RC2
>
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663304#action_12663304 ]
Niklas Gustavsson commented on FTPSERVER-262:
---------------------------------------------
I think we should release RC1 as it is. But, maybe we should do a RC2 with this and FTPSERVER-119 fixed?
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "Daniel Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663658#action_12663658 ]
Daniel Santos commented on FTPSERVER-262:
-----------------------------------------
rev 734250 fix my issue.
thx
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
> Assignee: Niklas Gustavsson
> Fix For: 1.0.0-RC2
>
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson closed FTPSERVER-262.
---------------------------------------
Resolution: Fixed
Fixed in rev 734250, please verify that this fixes your issues. We now dispose when the session is closed.
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
> Assignee: Niklas Gustavsson
> Fix For: 1.0.0-RC2
>
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "David Latorre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663305#action_12663305 ]
David Latorre commented on FTPSERVER-262:
-----------------------------------------
We should take into account that (I guess!) it is possible that the session be closed before the DataConnection ( so we can have a thread still writing to the filesystem).
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-262) FileSystemView.dispose() is never
called
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663477#action_12663477 ]
Niklas Gustavsson commented on FTPSERVER-262:
---------------------------------------------
> We should take into account that (I guess!) it is possible that the session be closed before the DataConnection ( so we can have a thread still writing to the filesystem).
That's a good point, but I think we should view it from the other side. Either we should not close the session before the data transfer is complete, or we should close the data transfer when the session closes. Keeping ongoing data transfers going without the session will lead to troubles. This is something we should have a look at, but I don't think it affects this issue.
> FileSystemView.dispose() is never called
> ----------------------------------------
>
> Key: FTPSERVER-262
> URL: https://issues.apache.org/jira/browse/FTPSERVER-262
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0.0-M4
> Reporter: Daniel Santos
> Assignee: Niklas Gustavsson
> Fix For: 1.0.0-RC2
>
>
> The FileSystemView.dispose() function is never called.
> This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.
> I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).
> thx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.