You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2011/07/15 22:39:32 UTC

svn commit: r1147314 - /subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c

Author: danielsh
Date: Fri Jul 15 20:39:32 2011
New Revision: 1147314

URL: http://svn.apache.org/viewvc?rev=1147314&view=rev
Log:
On the svn_mutex branch, rename variables for consistency.

* subversion/libsvn_subr/svn_mutex.c
  (uninit, svn_mutex__init): Call variables 'mutex' if and only if their type is 'svn_mutex__t *'.

Modified:
    subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c

Modified: subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c
URL: http://svn.apache.org/viewvc/subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c?rev=1147314&r1=1147313&r2=1147314&view=diff
==============================================================================
--- subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c (original)
+++ subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c Fri Jul 15 20:39:32 2011
@@ -27,19 +27,19 @@
 /* Destructor to be called as part of the pool cleanup procedure. */
 static apr_status_t uninit(void *data)
 {
-  svn_mutex__t **mutex = data;
-  *mutex = NULL;
+  svn_mutex__t **mutex_p = data;
+  *mutex_p = NULL;
 
   return APR_SUCCESS;
 }
 
 svn_error_t *
-svn_mutex__init(svn_mutex__t **mutex, 
+svn_mutex__init(svn_mutex__t **mutex_p, 
                 svn_boolean_t enable_mutex, 
                 apr_pool_t *pool)
 {
 #if APR_HAS_THREADS
-  *mutex = NULL;
+  *mutex_p = NULL;
   if (enable_mutex)
     {
       apr_thread_mutex_t *apr_mutex;
@@ -50,8 +50,8 @@ svn_mutex__init(svn_mutex__t **mutex, 
       if (status)
         return svn_error_wrap_apr(status, _("Can't create mutex"));
 
-      *mutex = apr_mutex;
-      apr_pool_cleanup_register(pool, mutex, uninit, apr_pool_cleanup_null);
+      *mutex_p = apr_mutex;
+      apr_pool_cleanup_register(pool, mutex_p, uninit, apr_pool_cleanup_null);
     }
 #else
   if (enable_mutex)

Re: svn commit: r1147314 - /subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c

Posted by Stefan Fuhrmann <eq...@web.de>.
On 15.07.2011 22:45, Greg Stein wrote:
> On Fri, Jul 15, 2011 at 16:39,<da...@apache.org>  wrote:
>> ...
>> +++ subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c Fri Jul 15 20:39:32 2011
>> ...
>>   svn_error_t *
>> -svn_mutex__init(svn_mutex__t **mutex,
>> +svn_mutex__init(svn_mutex__t **mutex_p,
>>                  svn_boolean_t enable_mutex,
>>                  apr_pool_t *pool)
> Would it be clearer to call that boolean "require_mutex" ?

Yes. Renamed in r1215460.

-- Stefan^2.

Re: svn commit: r1147314 - /subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c

Posted by Greg Stein <gs...@gmail.com>.
On Fri, Jul 15, 2011 at 16:39,  <da...@apache.org> wrote:
>...
> +++ subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c Fri Jul 15 20:39:32 2011
>...
>  svn_error_t *
> -svn_mutex__init(svn_mutex__t **mutex,
> +svn_mutex__init(svn_mutex__t **mutex_p,
>                 svn_boolean_t enable_mutex,
>                 apr_pool_t *pool)

Would it be clearer to call that boolean "require_mutex" ?

Cheers,
-g