You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/10/09 10:40:14 UTC

[PR] [CELEBORN-1026] Optimize registerShuffle fallback log [incubator-celeborn]

cxzl25 opened a new pull request, #1963:
URL: https://github.com/apache/incubator-celeborn/pull/1963

   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   According to https://github.com/apache/incubator-celeborn/pull/1955 , when celeborn is not available, `spark.dynamicAllocation.enabled=true` and  `spark.shuffle.service. enabled=true`, shuffle data should not be lost.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1026] Optimize registerShuffle fallback log [incubator-celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #1963:
URL: https://github.com/apache/incubator-celeborn/pull/1963#issuecomment-1757578892

   Merge to main/0.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1026] Optimize registerShuffle fallback log [incubator-celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #1963: [CELEBORN-1026] Optimize registerShuffle fallback log
URL: https://github.com/apache/incubator-celeborn/pull/1963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1026] Optimize registerShuffle fallback log [incubator-celeborn]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1963:
URL: https://github.com/apache/incubator-celeborn/pull/1963#issuecomment-1752783392

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1963?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1963](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1963?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6e979c3) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/c4135dc1b1e8fabf535da63107e66072c408885c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c4135dc) will **increase** coverage by `0.18%`.
   > Report is 1 commits behind head on main.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1963      +/-   ##
   ==========================================
   + Coverage   46.96%   47.13%   +0.18%     
   ==========================================
     Files         164      164              
     Lines       10361    10361              
     Branches      956      956              
   ==========================================
   + Hits         4865     4883      +18     
   + Misses       5178     5164      -14     
   + Partials      318      314       -4     
   ```
   
   
   [see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1963/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org