You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/01/22 22:07:32 UTC
[GitHub] [trafficserver] dbhat opened a new pull request #7441: Adding TCP Info logging support to header rewrite
dbhat opened a new pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441
This change to the header rewrite plugin allows TCP Info logs to be written out as part of the header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-772253789
It may be nice to have a subsection about `TXN_CLOSE_HOOK` under Hook Conditions section on the documentation. If I understand correctly, the hook is special because it's too late to modify/add response headers that will be sent to a client and it only makes sense if you add internal headers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-773655856
I will review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-766467434
[approve ci]
[add to whitelist]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
vmamidi commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-765796539
@dbhat Can you also update the documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dbhat commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
dbhat commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-772908138
@maskit: Added to documentation in [commit](https://github.com/apache/trafficserver/pull/7441/commits/d621cee2ad994349bfac1a3d2114cc50e3169559)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dbhat commented on a change in pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
dbhat commented on a change in pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#discussion_r568030314
##########
File path: doc/admin-guide/plugins/header_rewrite.en.rst
##########
@@ -515,6 +523,7 @@ The absence of an operand for conditions which accept them simply requires that
a value exists (e.g. the content of the header is not an empty string) for the
condition to be considered true.
+
Review comment:
Corrected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dbhat closed pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
dbhat closed pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-772979597
Rerunning autest. At minimum tests for header_rewrite pass on my MBP.
[approve ci autest]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-766467434
[approve ci]
[add to whitelist]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#issuecomment-773655856
I will review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #7441: Adding TCP Info logging support to header rewrite
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #7441:
URL: https://github.com/apache/trafficserver/pull/7441#discussion_r566408182
##########
File path: doc/admin-guide/plugins/header_rewrite.en.rst
##########
@@ -515,6 +523,7 @@ The absence of an operand for conditions which accept them simply requires that
a value exists (e.g. the content of the header is not an empty string) for the
condition to be considered true.
+
Review comment:
are these whitespace and `:wq` changes intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org