You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/01/28 08:24:23 UTC

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6499: Fixing pinot controller metrics prefix

fx19880617 opened a new pull request #6499:
URL: https://github.com/apache/incubator-pinot/pull/6499


   ## Description
   - Adding the missing DOT for controller metrics prefix
   - Update the JMX Prometheus config file to parse the new JMX metrics 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] yupeng9 commented on pull request #6499: Fixing pinot controller metrics prefix

Posted by GitBox <gi...@apache.org>.
yupeng9 commented on pull request #6499:
URL: https://github.com/apache/incubator-pinot/pull/6499#issuecomment-769388877


   Thanks @fx19880617 for the FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] fx19880617 commented on pull request #6499: Fixing pinot controller metrics prefix

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #6499:
URL: https://github.com/apache/incubator-pinot/pull/6499#issuecomment-769367089


   @yupeng9 please check your JMX metrics query code to see if this change will break your metrics reporting.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] fx19880617 commented on pull request #6499: Fixing pinot controller metrics prefix

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #6499:
URL: https://github.com/apache/incubator-pinot/pull/6499#issuecomment-768884649


   @chenboat @mayankshriv Please help check this won't break your metrics system.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] fx19880617 merged pull request #6499: Fixing pinot controller metrics prefix

Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #6499:
URL: https://github.com/apache/incubator-pinot/pull/6499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org