You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/17 18:24:33 UTC
[GitHub] [spark] MaxGekk edited a comment on issue #28244:
[SPARK-31471][TESTS][BUILD] Add a python script to run multiple benchmarks
MaxGekk edited a comment on issue #28244: [SPARK-31471][TESTS][BUILD] Add a python script to run multiple benchmarks
URL: https://github.com/apache/spark/pull/28244#issuecomment-615395592
> However, if this PR doesn't aim for all benchmark, I'm -1 for maintaining this partial one.
I don't understand your position. Let me ask you how often you run all benchmarks? My use case, and I believe this is most common use case is to run a few benchmarks and don't track each of them during night. Each time, I have to find my PR with the script and copy paste it to new EC2 instance.
> For personal use cases, I'd like to recommend to maintain your custom one privately.
but why? why you don't want to make life of other developers easier?
> for maintaining this partial one.
Maintaining? Don't think, the cost of maintaining of few lines is so high.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org